Print exports before unsets for shellinit

[bufdev]

Signed-off-by: Peter Edge peter.edge@gmail.com

I have TLS turned off. In my shell:

$ bash -version
GNU bash, version 4.3.33(1)-release (x86_64-apple-darwin14.1.0)
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

If boot2docker shellinit prints unsets before exports, I get the following:

$ x="$(boot2docker shellinit)"; echo $x; $($x)
unset DOCKER_CERT_PATH unset DOCKER_TLS_VERIFY export DOCKER_HOST=tcp://192.168.59.103:2375
bash: unset: `DOCKER_HOST=tcp://192.168.59.103:2375': not a valid identifier

It works fine if the exports come first:

$ x="$(boot2docker shellinit)"; echo $x; $($x)
export DOCKER_HOST=tcp://192.168.59.103:2375 unset DOCKER_CERT_PATH unset DOCKER_TLS_VERIFY

This is a quick fix, this is constantly been an annoyance. I know you have #351 going on but this is separate and easily merged. What do you think?

[tianon]

if you use eval "$x" instead of $($x), that should fix the problem (as mentioned in boot2docker/boot2docker#716 (comment) and our updated documentation from boot2docker/boot2docker#786). I'm a little leary of merging fixes that continue to encourage direct $(boot2docker shellinit) usage instead of passing it to eval.

[bufdev]

Totally up to you, I moved to docker-machine primarily re: deprecation notice. We can close this otherwise.

[tianon]

Sorry, this repository is long-since deprecated in favor of Docker Toolbox (whose usage is now also discouraged in favor of Docker for Windows and Docker for Mac).