Add classNameSize (Bootstrap optional sizes)

[ThibaudD]

A little option attribute for being able to use the Bootstrap optional sizes ("modal-lg", "modal-sm") that we have to add in the modal-dialog div. (http://getbootstrap.com/javascript/#modals-sizes)

Example for a large modal:

bootbox.dialog({
    message: "Large modal",
    title: "Large",
    classNameSize: "modal-lg"
});

[makeusabrew]

Hmm.

What a pity the class has to be added on the modal-dialog and not the outer wrapper (which we can already target). Either way, there are a few things which I think would benefit from addressing:

1. The option name is awkward. classNameSize is wrong, since you could pass any arbitrary class which may or may not affect the modal's size. innerClassName would be better, albeit ugly.

2. Related, I'm not sure if this should be exposed as a class name property, or just a "size" property. E.g. should it remain as you've done (but with a clearer name), or:

bootbox.dialog({
    message: "Large modal",
    title: "Large",
    size: "large"
});

Which internally applies whatever the relevant classes are in the relevant places. I'm leaning towards this, especially as the Bootstrap examples add classes to both the dialog and the outer wrapper (although they don't state that the outer ones are necessary).

3. It just needs a test covering the option being supplied to the dialog rather than just using setDefaults (belt & braces)

4. I don't scan the Bootstrap docs constantly by any means but I don't recognise the size options; are they new in 3.1.x? If so I'll need to update the supported versions and check everything else is okay (should be fine).

Thanks,

Nick

[ThibaudD]

2)I made the changes that you advised. It works like in your example ("large" or "small").
However I didn't see what to put in the outer wrapper (I think it is custom class in the bootstrap example).

3. I added tests covering the option for the dialog and modified the tests using setDefaults.

4. You're right. I checked the changelog, the size option is from the version 3.1.0

[lusabo]

When this option will be ready?