install: Add support for architecture filtering for kargs#567
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom May 28, 2024
Merged
install: Add support for architecture filtering for kargs#567cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
lukewarmtemp
force-pushed
the
merge-env-properties
branch
from
8d72f1a to
22eea93
Compare
cgwalters
reviewed
May 28, 2024
lukewarmtemp
force-pushed
the
merge-env-properties
branch
from
22eea93 to
8e31857
Compare
lukewarmtemp
changed the title
lukewarmtemp
force-pushed
the
merge-env-properties
branch
from
8e31857 to
03cedb6
Compare
cgwalters
reviewed
May 28, 2024
lukewarmtemp
force-pushed
the
merge-env-properties
branch
from
03cedb6 to
f57e312
Compare
cgwalters
reviewed
May 28, 2024
Collaborator
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Thanks! This is looking pretty close, just a nit on code duplication, and would you mind updating the docs on this?
The use case here is that some kernel arguments are architecture specific, such as the `console=` kargs. This allows a generic base image to default to including arch-specific values post install. `EnvProperties` struct to allow for conditional merging of kargs depending on whether the archiecture matches. Future properties such as `platform.id` can be added in the future. Signed-off-by: Luke Yang <luyang@redhat.com>
lukewarmtemp
force-pushed
the
merge-env-properties
branch
from
f57e312 to
cdeadb9
Compare
cgwalters
approved these changes
May 28, 2024
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
ci: Adapt for Fedora 39
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 6, 2024
encapsulate: Support setting arbitrary container config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for #401
Adds a
EnvPropertiesstruct to allow for conditional merging of kargs depending on whether the archiecture matches. Future properties such asplatform.idcan be added in the future.Signed off: Luke Yang luyang@redhat.com