install: Make stateroot configurable#622
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Sep 9, 2024
Merged
Conversation
cgwalters
reviewed
Jun 21, 2024
Collaborator
|
For tests, try adding a new case to https://github.com/containers/bootc/blob/b5f47ff8fe5121f7eade46aa53048edd75fd6116/tests-integration/src/install.rs#L68 |
omertuc
force-pushed
the
installstateroot
branch
3 times, most recently
from
8e9e129 to
c093213
Compare
cgwalters
reviewed
Jun 26, 2024
cgwalters
approved these changes
Jul 3, 2024
Collaborator
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Looks sane to me, could just use a test in tests-integration/src/install.rs or so.
Contributor
Author
Coming back to this, is this still the right place? Or should it be part of the e2e tmt stuff? |
omertuc
force-pushed
the
installstateroot
branch
3 times, most recently
from
89cf7ff to
3b92943
Compare
omertuc
force-pushed
the
installstateroot
branch
2 times, most recently
from
4bdd3c7 to
6edca4e
Compare
omertuc
commented
Sep 3, 2024
omertuc
commented
Sep 3, 2024
omertuc
force-pushed
the
installstateroot
branch
from
6edca4e to
f0ab159
Compare
Collaborator
the e2e-tmt flow is generally oriented around bootc as a client flow, which is currently pretty distinct from the install path. I think it's still the right place to test install code in that file. |
omertuc
force-pushed
the
installstateroot
branch
from
f0ab159 to
ceae92b
Compare
This commit makes it so that the `bootc install` stateroot will be configurable (it defaults to `default`). For now this is a hidden CLI option until we decide whether we want to commit to this API. In the future we also want to make the stateroot of `bootc switch` be configurable (bootc-dev#617) so that users can install an image to a new stateroot while they already have an existing stateroot Also removed the constant `STATEROOT_DEFAULT`, we're now simply taking it from the `ostree_ext` crate Signed-off-by: Omer Tuchfeld <omer@tuchfeld.dev>
omertuc
force-pushed
the
installstateroot
branch
from
ceae92b to
d17e471
Compare
cgwalters
approved these changes
Sep 9, 2024
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
….0.197 build(deps): bump serde from 1.0.196 to 1.0.197
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Nov 6, 2024
container: Drop async_compression + support zstd:chunked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes it so that the
bootc installstateroot will be configurable (it defaults todefault). For now this is a hidden CLI option until we decide whether we want to commit to this API.In the future we also want to make the stateroot of
bootc switchbe configurable (#617) so that users can install an image to a new stateroot while they already have an existing staterootAlso removed the constant
STATEROOT_DEFAULT, we're now simply taking it from theostree_extcrate