Skip to content

test: add centos stream 10 rpm build and e2e test#743

Merged
henrywang merged 4 commits intobootc-dev:mainfrom
henrywang:cs10
Aug 1, 2024
Merged

test: add centos stream 10 rpm build and e2e test#743
henrywang merged 4 commits intobootc-dev:mainfrom
henrywang:cs10

Conversation

@henrywang
Copy link
Copy Markdown
Collaborator

@henrywang henrywang commented Jul 31, 2024

This PR includes:

  1. add centos stream 10 all arch rpm build
  2. add e2e test for centos stream 10

@henrywang
test: add centos stream 10 rpm build and e2e test
98201fe 
Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
cgwalters
cgwalters approved these changes Jul 31, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, though one issue is the matrix here is getting pretty large, and fairly often we hit "artemis" provisioning failures e.g.

henrywang added 3 commits July 31, 2024 23:48
@henrywang
test: disable selinux on CS10 to workaround libvirt selinux issue
b3cead0 
Workaround issue https://issues.redhat.com/browse/RHEL-46893

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
@henrywang
test: remove kargs "systemd.unified_cgroup_hierarchy=0"
714b77c 
"systemd.unified_cgroup_hierarchy=0" does not work with CS10
It caused boot failure with error:
[!!!!!!] Refusing to run under cgroup v1, SY… specified on kernel
command line.

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
@henrywang
test: update / mount SOURCE checking case
a657b76 
SOURCE can be overlay, none or composefs

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
@henrywang
Copy link
Copy Markdown
Collaborator Author

henrywang commented Aug 1, 2024 •
edited
Loading

Hi @lukewarmtemp, I found systemd.unified_cgroup_hierarchy=0 was added in PR #594.

I have to remove it in this PR because it caused boot failure on CS10 with error: [!!!!!!] Refusing to run under cgroup v1, SY… specified on kernel command line. CS10 deprecated boot from cgruop v1.

I there any test impact of remove this karg? Thanks.

@lukewarmtemp
Copy link
Copy Markdown
Contributor

lukewarmtemp commented Aug 1, 2024

I there any test impact of remove this karg? Thanks.

You're free to remove it. Sorry, I just arbitrarily chose some kargs to test and didn't realize that it might conflict with others.

@cgwalters
Copy link
Copy Markdown
Collaborator

cgwalters commented Aug 1, 2024

Yes, we should definitely not set that.

@henrywang
Copy link
Copy Markdown
Collaborator Author

henrywang commented Aug 1, 2024

Looks sane, though one issue is the matrix here is getting pretty large, and fairly often we hit "artemis" provisioning failures e.g.

Yes. The most of time (99%) the provisioning issue happens on x86_64 runner machine. Looks the aarch64 runner does not hit the quota.

  • In to-disk test, I removed centos-stream-9-x86_64 and added centos-stream-10-x86_64. No additional x86_64 test added.
  • I added centos-stream-10-aarch64 in both to-disk and to-existing-root tests.

@henrywang henrywang marked this pull request as ready for review August 1, 2024 15:24
@henrywang henrywang merged commit 12828ea into bootc-dev:main Aug 1, 2024
@henrywang henrywang deleted the cs10 branch August 1, 2024 16:12
cgwalters pushed a commit to cgwalters/bootc that referenced this pull request Nov 5, 2024
@HuijingHei
Merge pull request bootc-dev#743 from HuijingHei/release-0224
0972dee 
Release 0.2.24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henrywang @lukewarmtemp @cgwalters