ci: Resync#61
Merged
cgwalters merged 2 commits intobootc-dev:mainfrom Mar 5, 2026
Merged
Conversation
Add [lints.rust] and [lints.clippy] sections to Cargo.toml, matching the lint policy from bootc-dev/bootc. This includes forbidding unsafe_code, forbidding unused_must_use, denying dead_code, dbg_macro, todo, and requiring Debug implementations on public types. The missing_docs lint remains as a crate-level attribute in lib.rs rather than in Cargo.toml because cargo lints apply to all targets including examples, which don't need module-level docs. Also adds a manual Debug implementation for LayerWriter, which was missing one. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
Replace the hardcoded ACTIONS_LINTS_TOOLCHAIN pin (1.86.0) with bootc-dev/actions/setup-rust which uses stable Rust. The pinned version was causing lint failures on PRs that use features stabilized after 1.86 (e.g. let chains from 1.87). Merge the separate tests and linting jobs into a single job that runs `just lint` and `just test`, keeping CI and local development in sync. The Justfile prefers nextest when available and falls back to cargo test otherwise. Also removes the old coreos/repo-templates header since this repo is now maintained under bootc-dev, and bumps actions/checkout to v6. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively resynchronizes CI-related configurations across crates by introducing new lint rules in Cargo.toml and a comprehensive Justfile for build, test, and lint commands. The added Debug implementation for LayerWriter in src/lib.rs improves debuggability.
ckyrouac
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal is re-synchronizing things like lints, semver checks etc across our crates.