Include edgeOffset in layout calculation #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10xjs
force-pushed
the
calculate-edge-offset
branch
from
3c11cfc to
9d92fb0
Compare
`edgeOffset` is used to represent a margin at the the bounds rect edge. Previously it was only a prop used within the `FlowTip` react component that was subtracted from the resolved `bounds` rect, effectively shrinking it. This had the undesirable effect of also applying the margin to between the positioned tooltip and viewport edge when the target was outside the viewport. What we really want the tail side of the tooltip to have its own margin, separate from the body. When the tooltip is positioned at the screen edge, the larger of the two margins will determine the final position.
10xjs
force-pushed
the
calculate-edge-offset
branch
from
9d92fb0 to
9c9eb02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edgeOffsetis used to represent a margin at the the bounds rect edge. Previously it was only a prop used within theFlowTipreact component that was subtracted from the resolvedboundsrect, effectively shrinking it. This had the undesirable effect of also applying the margin to between the positioned tooltip and viewport edge when the target was outside the viewport.What we really want the tail side of the tooltip to have its own margin, separate from the body. When the tooltip is positioned at the screen edge, the larger of the two margins will determine the final position.
Before:
At the boundary edge,
offsetandtargetOffsetare be added together.After:
At the boundary edge, only largest of
offsetandtargetOffsetis used.