Skip to content

Conversation

@10xjs
Copy link
Contributor

@10xjs 10xjs commented Mar 22, 2018

Add an es module build for consumers wanting module tree-shaking.

The build scripts have been cleaned up and moved to the top-level package.json to get rid of duplication across packages.

Copy link
Contributor

@izaakschroeder izaakschroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea seems good to me. Only thought: Not sure what @babel/preset-env does without any targets. Don't know what level of determinism is provided.

Add an es module build for consumers wanting module tree-shaking.

The build scripts have been cleaned up and moved to the top-level `package.json` to get rid of duplication across packages.
@10xjs
Copy link
Contributor Author

10xjs commented Mar 22, 2018

GP about targets. Avoiding any change there.

@10xjs 10xjs merged commit b7cc0ab into master Mar 22, 2018
@10xjs 10xjs deleted the es-modules branch March 22, 2018 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants