Support for Bootstrap 4

[stujo]

Hi I'm working on support for bootstrap 4 for a project here:

https://github.com/stujo/rails-bootstrap-forms/tree/support-bootstrap-4

Please let me know if I can be of any assistance

Cheers
Stu

[gcrofils]

Hi. I m starting to use Bootstrap 4 for a new project.
What have you done so far ?
I would be very happy to contribute.

[stujo]

Cool, really the only change I've had to make so far was to change has-error to has-danger

https://github.com/stujo/rails-bootstrap-forms/commits/support-bootstrap-4

It might be possible to keep has-error and use scss instead

Happy to work together

[mattbrictson]

I'm assuming supporting Bootstrap 4 will break backwards compatibility with Bootstrap 3, since the class names are different. Am I correct?

If so, that means we'll need a strategy for how to support both v3 and v4 with the bootstrap_rails gem. I'm open to suggestions! Some ideas:

• Have v3 and v4 "modes" within the gem that can be switched using e.g. a Rails initializer.
• Branch the gem and release two different versions: the current 2.x series will continue support Bootstrap v3, and a new 3.x (or better, 4.x) series will support Bootstrap v4.

I guess it depends on how much different v3 and v4 are. Thoughts?

[stujo]

@mattbrictson Looks like there are some differences, I'd lean towards having a version of the library which 'does one thing well' - in this case 'supports v4'.

If it turns out that a mode switch is easy then adding that later could be an option and the changes could be merged into upstream

If not then the library with v4 support could be renamed to something like rails-bootstrap-v4-forms

Thoughts?

[mattbrictson]

If there are major differences in the markup that is generated, then I agree we should package it as a completely new gem.

[stujo]

Great, let's see how it plays out!

[johnvuko]

Currently in rails-bootstrap-forms, the submit button in the form use btn-default.

In bootstrap 4, btn-default is renamed by btn-secondary
Here the link suggesting to rename according to the migration:
http://v4-alpha.getbootstrap.com/migration/#buttons

But if you look at the form exemple, they replace btn-default by btn-primary, which seems more logic:
http://v4-alpha.getbootstrap.com/components/forms/

Thankfully, there is the method primary for now.

[desheikh]

Created a PR with a fairly complete list of changes for bootstrap v4 support #304. The changes themselves are fairly minor.
@mattbrictson Could we get a v4 branch up so that we can track changes/fixes centrally?

[mattbrictson]

@desheikh Good idea. I've created a bootstrap-v4 branch.

[desheikh]

@mattbrictson Thanks! Switched the PR to point to the new branch.

[krsyoung]

I'm currently working off of bootstrap-v4 branch with the alpha6 release. Has anybody here created a horizontal form (https://v4-alpha.getbootstrap.com/components/forms/#using-the-grid)? I'm trying to figure out if it could be handled via the previous layout: 'horizontal' approach (removed in #304) or if we should just be avoiding the library in this case due to how generic the grid is?

UPDATE: scratch that! I was using 'horizontal' vs :horizontal. Oops.