Support :prepend and :append for the select helper#325
Merged
mattbrictson merged 1 commit intobootstrap-ruby:masterfrom Apr 20, 2017
donv:master
Merged
Support :prepend and :append for the select helper#325mattbrictson merged 1 commit intobootstrap-ruby:masterfrom donv:master
select helper#325mattbrictson merged 1 commit intobootstrap-ruby:masterfrom
donv:master
Conversation
Contributor
mattbrictson
left a comment
mattbrictson
left a comment
There was a problem hiding this comment.
Great, thanks for the PR! ✨
I just found one nitpick in the test. Let me know if you think that needs to be corrected before I merge.
| <select class="form-control" id="user_status" name="user[status]"><option value="1">activated</option> | ||
| <option value="2">blocked</option></select> | ||
| <span class="input-group-addon">After</span> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Is there another </div> needed here?
Collaborator
Author
There was a problem hiding this comment.
Yes, absolutely. I added the </div> and structured the HTML example a little better as well.
Contributor
|
Awesome, thank you 🙌 |
Collaborator
Author
|
@mattbrictson How do we propagate this to the bootstrap-v4 branch? |
Contributor
Collaborator
Author
|
@mattbrictson OK, will do. |
Collaborator
Author
|
@mattbrictson OK, added #327 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147