Add bootstrap 4.beta validation style#340
Closed
jvanbaarsen wants to merge 11 commits intobootstrap-ruby:bootstrap-v4from
Closed
Add bootstrap 4.beta validation style#340jvanbaarsen wants to merge 11 commits intobootstrap-ruby:bootstrap-v4from
jvanbaarsen wants to merge 11 commits intobootstrap-ruby:bootstrap-v4from
Conversation
) * Support :prepend and :append for the `select` helper Fixes bootstrap-ruby#147 * Bootstrap 4 has renamed `control-label` to `form-control-label`
Bootstrap has changed the way they are showing validation messages, this also means the css classes have changed. This updates the code generated to reflect that. Fixes: bootstrap-ruby#339
donv
reviewed
Sep 4, 2017
|
|
||
| options[:class] = ["form-group", options[:class]].compact.join(' ') | ||
| options[:class] << " row" if get_group_layout(options[:layout]) == :horizontal | ||
| options[:class] << " #{error_class}" if has_error?(name) |
Collaborator
There was a problem hiding this comment.
The label should be red as well, using the "text-danger" error_clas, right?
mattbrictson
force-pushed
the
bootstrap-v4
branch
from
16d82d6 to
a68a242
Compare
Collaborator
|
@jvanbaarsen thanks for the PR. However Beta 3 has changes the way validations work now though. Closing this as #370 updates things to the new syntax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap has changed the way they are showing validation messages, this also
means the css classes have changed.
This updates the code generated to reflect that.
Fixes: #339