Skip to content

Additional Form Group Attributes in select example#352

Merged
mattbrictson merged 3 commits intobootstrap-ruby:masterfrom
r-sierra:patch-1
Jan 10, 2018
Merged

Additional Form Group Attributes in select example#352
mattbrictson merged 3 commits intobootstrap-ruby:masterfrom
r-sierra:patch-1

Conversation

@r-sierra
Copy link
Copy Markdown
Contributor

Show how to set additional Form Group Attributes like wrapper class

Show how to set additional Form Group Attributes like wrapper class
Copy link
Copy Markdown
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Approved once PR #355 is merged.

Comment thread README.md Outdated

```erb
<%= f.select :product, [[1, "Apple"], [2, "Grape"]], { label: "Choose your favorite fruit:" }, { class: "selectpicker" } %>
<%= f.select :product, [[1, "Apple"], [2, "Grape"]], { label: "Choose your favorite fruit:" }, { class: "selectpicker", wrapper: { class: 'has-warning', data: { foo: 'bar' } } %>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there was a typo in the original README.md. PR #355 will fix the typo, at which time this line will probably have a merge conflict. Please wait for the other PR to be merged, fix the conflict if any, and then we can merge this PR.

@mattbrictson
Copy link
Copy Markdown
Contributor

@r-sierra would you mind rebasing against the latest master and resolving the conflict? Thanks!

@r-sierra
Copy link
Copy Markdown
Contributor Author

@mattbrictson conflict solved!

Missing "}"
@mattbrictson
Copy link
Copy Markdown
Contributor

Much appreciated! 🙇

@mattbrictson mattbrictson merged commit 1be02fa into bootstrap-ruby:master Jan 10, 2018
unikitty37 pushed a commit to unikitty37/rails-bootstrap-forms that referenced this pull request Jan 12, 2018
* Additional Form Group Attributes in select example

Show how to set additional Form Group Attributes like wrapper class

* Update README.md

Missing "}"
lcreid pushed a commit to lcreid/rails-bootstrap-forms that referenced this pull request Jun 4, 2018
* Additional Form Group Attributes in select example

Show how to set additional Form Group Attributes like wrapper class

* Update README.md

Missing "}"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants