Pin Minitest to work around crash on test failure.#372
Merged
donv merged 1 commit intobootstrap-ruby:masterfrom Jan 11, 2018
Merged
Pin Minitest to work around crash on test failure.#372donv merged 1 commit intobootstrap-ruby:masterfrom
donv merged 1 commit intobootstrap-ruby:masterfrom
Conversation
Minitest 5.11 is broken for environments, like Rails, that use custom reporters. Pin to 5.10.3 in the meantime.
Collaborator
|
Thanks! |
Contributor
|
I could be wrong, but my understanding based on this thread #366 (comment) is that whenever we add or pin a dependency we have to repeat it in each of the Gemfiles. I.e. Also, shouldn't |
Contributor
|
Yes. This PR wasn't ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minitest 5.11 is broken for environments, like Rails, that use custom reporters. Pin to 5.10.3 in the meantime.
Addresses issue #371.