Use Bootstrap 4 radio button classes.#409
Merged
mattbrictson merged 1 commit intobootstrap-ruby:masterfrom Jan 28, 2018
Merged
Conversation
Here's an example of a CHANGELOG.md entry (place it immediately under the * [#409](https://github.com/bootstrap-ruby/bootstrap_form/pull/409): Use Bootstrap 4 radio button classes. - [@lcreid](https://github.com/lcreid).Generated by 🚫 Danger |
Contributor
|
Nice, bite-sized PR. Thanks! 👍 |
lcreid
added a commit
to lcreid/rails-bootstrap-forms
that referenced
this pull request
Jan 28, 2018
mattbrictson
pushed a commit
that referenced
this pull request
Jan 29, 2018
* Inline checkboxes. * Rebase from PR #409.
lcreid
added a commit
to lcreid/rails-bootstrap-forms
that referenced
this pull request
Jun 4, 2018
…ap-ruby#410) * Inline checkboxes. * Rebase from PR bootstrap-ruby#409.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the correct Bootstrap 4 classes for radio buttons.
This PR corrects the classes on inline radio buttons, but does not address the overall format (wrapping) of inline radio buttons for Bootstrap 4. That will be in a separate PR.
There is some redundancy in this code, because I chose to try to minimize changes to achieve the desired functionality, rather than refactor to the DRYest state. I expect that the code will naturally get DRYer in the next PR, and that any remaining DRYing up can be handled by a separate PR later.
This is part of the work for #395.