Test the rendering of errors for various controls.#424
Merged
mattbrictson merged 4 commits intobootstrap-ruby:masterfrom Feb 17, 2018
Merged
Test the rendering of errors for various controls.#424mattbrictson merged 4 commits intobootstrap-ruby:masterfrom
mattbrictson merged 4 commits intobootstrap-ruby:masterfrom
Conversation
Contributor
|
Nice work. Always good to have additional test coverage where it makes sense. 💯 |
lcreid
added a commit
to lcreid/rails-bootstrap-forms
that referenced
this pull request
Jun 4, 2018
* Test selects error. * Add tests for date, time, datetime selects. * date, time, datetime tests pass with old implementation. * Tests for file and collection selects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for various controls when there is an validation failure on the control. All these tests document the behaviour of the master branch as of the time the PR was created.
Bootstrap 4's handling of errors is different that Bootstrap 3's, and has led to some issues already, e.g. #417 and #395. The tests here, therefore, document current functionality, so they give us a baseline for any required changes. These tests should not be considered a declaration about how
bootstrap_formshould render errors with Bootstrap 4.These tests also provide more coverage to ensure we don't introduce regressions as we address #417, #395 and any other issues that come up.
Given this PR contains only a few tests which don't significantly increase the run time of the test suite, I hope it's easy to merge. It would be great if someone other that @mattbrictson can review this PR, to take some of the load off Matt's shoulders.