Allow .form-row to replace .row in div.form-group.#459
Merged
mattbrictson merged 3 commits intobootstrap-ruby:masterfrom May 28, 2018
Merged
Allow .form-row to replace .row in div.form-group.#459mattbrictson merged 3 commits intobootstrap-ruby:masterfrom
mattbrictson merged 3 commits intobootstrap-ruby:masterfrom
Conversation
Contributor
|
Thanks! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Bootstrap 3,
.form-groupmixed in.row. In Bootstrap 4, it doesn't. Sobootstrap_formautomatically adds.rowto thediv.form-groups that it creates, if the form group is in a horizontal layout.Bootstrap 4 provides a
.form-row, which has smaller gutters than.row. If the programmer specifies ".form-row",bootstrap_formwill replace.rowwith.form-rowon thediv.form-groupon horizontal forms.UPGRADE-4.0.mdonly mentions changes from this PR, assuming that the complete version ofUPGRADE-4.0.mdwill be merged from PR #448.Fixes #449.