Test multiple filesystems with Vagrant by PlasmaPower · Pull Request #1359 · borgbackup/borg

PlasmaPower · 2016-07-22T20:32:15Z

Both kernel module and FUSE filesystems are supported.

TODO:

Filesystems requiring a device
- ext4
- XFS
- NTFS
Filesystems requiring a server
- CIFS
- SSHFS
Filesystems requiring neither
- tmpfs check_free_space triggers TypeError in LoggedIO.cleanup #1821
Fix FS specific test issues
- test_non_ascii_acl failing #1361 - test_non_ascii_acl only failed outside of Vagrant due to übel user missing
- Tests failing on SSHFS #1362 - tests failing on SSHFS (fixed with Filesystem feature detection and test skipping #1373)
- Tests failing on ntfs-3g #1363 - tests failing on ntfs-3g (fixed with Filesystem feature detection and test skipping #1373 + Skip mode tests with BORG_TESTS_IGNORE_MODES #1383)
Platform specific Vagrant testing
- Linux
  - centos7_64
  - centos6_32
  - centos6_64
  - xenial64
  - trusty64
  - jessie64
  - wheezy32
  - wheezy64
- OS X
  - darwin64
- BSD
  - freebsd64
  - openbsd64
  - netbsd64

PlasmaPower · 2016-07-23T00:42:33Z

Okay, first network based FS is implemented (SSHFS). Implementation is a bit hacky (e.g. rootTestingDir hardcoded in sshd_config, couldn't get ChrootDirectory working), but I've made sure to comment it well and it should work fine as-is.

PlasmaPower · 2016-07-23T00:51:31Z

nfsd is... interesting. It seems to be implemented as a kernel module. It also has no way to specify a custom config file location from what I can tell, meaning that I can't easily automate it. I'm going to not test NFS, at least for now.

PlasmaPower · 2016-07-23T02:08:37Z

Okay, CIFS is done after a lot of trouble with configuration. That means all the filesystems I was planning to test (except NFS which I couldn't) are done! Any more recommendations?

I'm now going to test if borg actually succeeds in these filesystems (I'm expecting they'll be bugs :/).

PlasmaPower · 2016-07-23T04:10:09Z

Okay, I've added all the drivers I could find to the Vagrantfile, but I might have missed some and some might not exist that I thought existed (or had different names). I'm going to wait on the FS specific issues to be fixed before moving forward though, wouldn't want to have to redo everything.

ThomasWaldmann · 2016-07-23T08:52:17Z

vagrant-tools/run-tests.sh

+fi
+# otherwise: just use the system python
+
+testingPartitionSize=128M


what is the minimum that would safely work?

I don't know, and I would like to support future tests. The FS minimum size is usually small, around 10M, so I don't think that's a big problem. Maybe we should drop this to 16M? I'll check that

Looks like 16M works. Switching to that now.

16M fails on NTFS, switching to 32M.

I've switched it back to 16M with a custom value of 128M for NTFS because it still runs out at 32M.

PlasmaPower · 2016-07-23T16:19:15Z

I think I'm setting some naming conventions here, @ThomasWaldmann do you agree with them? I can change them of course.

enkore · 2016-07-23T16:20:03Z

vagrant-tools/smb.conf

+map to guest = Bad User
+
+# Who thought it was a good idea
+# to put printing in a file sharing protocol?


ThomasWaldmann · 2016-07-24T09:25:37Z

names should be like in pep8.

PlasmaPower · 2016-07-24T12:27:03Z

@ThomasWaldmann Should the names of files/directories also be snake_case? I'm currently using dashes as delimiters, but I can easily switch.

ThomasWaldmann · 2016-07-24T14:47:45Z

dashes in file/dirnames are fine imho.

PlasmaPower · 2016-07-31T02:10:26Z

That seems like it'll eliminate a number of problems, and enable more tests. I'll switch all the provision commands over to privileged in the Vagrantfile, remove the sudo -u vagrant in the test driver, and do some testing.

PlasmaPower · 2016-07-31T20:23:50Z

I'm getting really odd errors on CIFS. I've put the debugging info in this gist because it's a bit long.

PlasmaPower · 2016-07-31T21:23:18Z

I'd appreciate help debugging that error. I'm not really sure what's causing it.

ThomasWaldmann · 2016-07-31T22:07:54Z

Well, seems like a crash in pytest itself.

PlasmaPower · 2016-07-31T22:09:06Z

It does, but I find it odd that it occurs right after a failure in one of our tests.

Maybe I should just disable CIFS?

PlasmaPower · 2016-08-02T16:51:57Z

I can't figure this issue out, so for now at least I'm just disabling CIFS. We already are testing a network based FS anyway.

ThomasWaldmann · 2016-08-02T18:10:04Z

Pity. Maybe we can enable it again later, CIFS is quite popular, even for internet storage boxes.

PlasmaPower · 2016-08-03T17:50:42Z

Yeah, in my local changeset (will push after testing FreeBSD) it's just continued past with a comment explaining the problem. Hopefully that means it'll be easy to re-enable if the problem gets fixed.

Also, I'm getting some errors on FreeBSD, issue will be up with detailed information soon.

PlasmaPower · 2016-08-03T18:42:14Z

Once #1416 and #1434 have been resolved, I'll rerun the tests, and then this should be good to merge.

PlasmaPower · 2016-08-21T18:40:55Z

Okay, I'm going to revisit the PR to rerun tests now that some of them should have been fixed.

codecov-io · 2016-09-07T04:08:02Z

Current coverage is 85.43% (diff: 100%)

Merging #1359 into master will increase coverage by 0.04%

@@             master      #1359   diff @@
==========================================
  Files            19         19          
  Lines          6125       6125          
  Methods           0          0          
  Messages          0          0          
  Branches       1033       1033          
==========================================
+ Hits           5230       5233     +3   
+ Misses          645        643     -2   
+ Partials        250        249     -1

Powered by Codecov. Last update d3cea70...21e6384

PlasmaPower · 2016-09-07T04:26:33Z

I've been really busy, but I currently have some time to work on this (and I should be relatively free for a while). I'm running tests for wheezy32 now, I'll post logs if anything comes up of course.

It's unfortunate that the whole thing has to be rebuilt and dependencies have to be reinstalled for each filesystem. Is there a workaround that I could use?

ThomasWaldmann · 2016-10-05T23:57:25Z

@PlasmaPower not sure what you mean with rebuilt/reinstalled for each filesystem.

but as a general remark: we'll soon have 1.1.0b3 and likely that will be the last beta, follow by 1+ release candidate. so it would be good to get your PR finished soon, so it can be in 1.1.0 release.

ThomasWaldmann · 2016-10-05T23:59:28Z

another thing: I'ld like to keep the count of toplevel items in the repo low, so how about moving the stuff from vagrant-tools/... to scripts/vagrant/... ?

PlasmaPower · 2016-10-16T18:55:03Z

If anyone else wants to pick up this PR (and claim the bounty), that's fine. The test time is simply too long to try to fix a lot of small issues. Each time tox is run with a different TMPDIR it seems to reinstall dependencies, I haven't looked into preventing this, a symlink in the TMPDIR to a central location might fix it.

PlasmaPower · 2016-10-16T18:56:43Z

And yes, tests are failing on various filesystems, but a lot of the time it's hard to tell where the problem is coming from and if it's the actual tests or just my test driver. Also, it seems to also be somewhat OS dependent.

ThomasWaldmann · 2016-11-10T03:03:02Z

continued in #1820.

PlasmaPower · 2016-11-10T03:55:26Z

Great! I've followed that issue, I'll be happy to help if you're wondering why something's there/what is does.

PlasmaPower force-pushed the vagrant-multiple-fs branch 3 times, most recently from 0b43240 to c6db6e5 Compare July 23, 2016 00:38

PlasmaPower force-pushed the vagrant-multiple-fs branch from c6db6e5 to 9f81903 Compare July 23, 2016 02:07

PlasmaPower force-pushed the vagrant-multiple-fs branch 3 times, most recently from 9ed8620 to f57427c Compare July 23, 2016 03:14

This was referenced Jul 23, 2016

test_non_ascii_acl failing #1361

Closed

Tests failing on SSHFS #1362

Closed

Tests failing on ntfs-3g #1363

Closed

PlasmaPower force-pushed the vagrant-multiple-fs branch from f57427c to 302f1ce Compare July 23, 2016 03:44

PlasmaPower changed the title ~~Test multiple filesystems with Vagrant [WIP]~~ Test multiple filesystems with Vagrant Jul 23, 2016

PlasmaPower force-pushed the vagrant-multiple-fs branch from 302f1ce to ca38a06 Compare July 23, 2016 04:09

ThomasWaldmann reviewed Jul 23, 2016
View reviewed changes

PlasmaPower force-pushed the vagrant-multiple-fs branch 4 times, most recently from a9d06de to f02d87d Compare July 23, 2016 14:41

enkore reviewed Jul 23, 2016
View reviewed changes

PlasmaPower force-pushed the vagrant-multiple-fs branch from f02d87d to e4ce1f3 Compare July 23, 2016 17:04

PlasmaPower force-pushed the vagrant-multiple-fs branch 2 times, most recently from c55dba5 to ac7afa9 Compare July 31, 2016 14:28

PlasmaPower force-pushed the vagrant-multiple-fs branch from 90e0af6 to b8ba248 Compare August 3, 2016 18:48

enkore added this to the 1.1.0b2 milestone Aug 27, 2016

Test multiple filesystems with Vagrant

21e6384

PlasmaPower force-pushed the vagrant-multiple-fs branch from b8ba248 to 21e6384 Compare September 7, 2016 03:50

ThomasWaldmann modified the milestones: 1.1.0b3, 1.1.0b2 Sep 16, 2016

ThomasWaldmann self-assigned this Nov 10, 2016

ThomasWaldmann closed this Nov 10, 2016

ThomasWaldmann removed this from the 1.1.0b3 milestone Nov 10, 2016

ThomasWaldmann mentioned this pull request Nov 10, 2016

WIP Test multiple filesystems with Vagrant #1820

Closed

22 tasks

Uh oh!

Conversation

PlasmaPower commented Jul 22, 2016 • edited by ThomasWaldmann Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PlasmaPower commented Jul 23, 2016

Uh oh!

PlasmaPower commented Jul 23, 2016

Uh oh!

PlasmaPower commented Jul 23, 2016

Uh oh!

PlasmaPower commented Jul 23, 2016

Uh oh!

ThomasWaldmann Jul 23, 2016

Choose a reason for hiding this comment

Uh oh!

PlasmaPower Jul 23, 2016

Choose a reason for hiding this comment

Uh oh!

PlasmaPower Jul 23, 2016

Choose a reason for hiding this comment

Uh oh!

PlasmaPower Jul 23, 2016

Choose a reason for hiding this comment

Uh oh!

PlasmaPower Jul 23, 2016

Choose a reason for hiding this comment

Uh oh!

PlasmaPower commented Jul 23, 2016

Uh oh!

enkore Jul 23, 2016

Choose a reason for hiding this comment

Uh oh!

ThomasWaldmann commented Jul 24, 2016

Uh oh!

PlasmaPower commented Jul 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThomasWaldmann commented Jul 24, 2016

Uh oh!

PlasmaPower commented Jul 31, 2016

Uh oh!

PlasmaPower commented Jul 31, 2016

Uh oh!

PlasmaPower commented Jul 31, 2016

Uh oh!

ThomasWaldmann commented Jul 31, 2016

Uh oh!

PlasmaPower commented Jul 31, 2016

Uh oh!

PlasmaPower commented Aug 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThomasWaldmann commented Aug 2, 2016

Uh oh!

PlasmaPower commented Aug 3, 2016

Uh oh!

PlasmaPower commented Aug 3, 2016

Uh oh!

PlasmaPower commented Aug 21, 2016

Uh oh!

codecov-io commented Sep 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 85.43% (diff: 100%)

Uh oh!

PlasmaPower commented Sep 7, 2016

Uh oh!

ThomasWaldmann commented Oct 5, 2016

Uh oh!

ThomasWaldmann commented Oct 5, 2016

Uh oh!

PlasmaPower commented Oct 16, 2016

Uh oh!

PlasmaPower commented Oct 16, 2016

Uh oh!

ThomasWaldmann commented Nov 10, 2016

Uh oh!

PlasmaPower commented Nov 10, 2016

Uh oh!

Reviewers

PlasmaPower commented Jul 22, 2016 •

edited by ThomasWaldmann

Loading

PlasmaPower commented Jul 24, 2016 •

edited

Loading

PlasmaPower commented Aug 2, 2016 •

edited

Loading

codecov-io commented Sep 7, 2016 •

edited

Loading