Conversation
Codecov Report
@@ Coverage Diff @@
## master #2873 +/- ##
==========================================
- Coverage 86.26% 86.25% -0.02%
==========================================
Files 23 23
Lines 8826 8826
Branches 1486 1486
==========================================
- Hits 7614 7613 -1
Misses 820 820
- Partials 392 393 +1
Continue to review full report at Codecov.
|
src/borg/archiver.py
Outdated
| Number of files: {stats[nfiles]} | ||
| Command line: {command_line} | ||
| Utilization of max. archive size: {limits[max_archive_size]:.0%} | ||
| Utilization of maximum possible archive size: {limits[max_archive_size]:.0%} |
There was a problem hiding this comment.
Yes, that's more clear.
src/borg/archiver.py
Outdated
| = all chunks in the repository. | ||
| = all chunks in the repository. | ||
|
|
||
| Borg only supports archives up to a certain size. The size of an archive |
There was a problem hiding this comment.
well, this is correct, but can be misunderstood by users who do not know that content data lives outside of the archive. so maybe rather say "... archive metadata streams up to ...".
src/borg/archiver.py
Outdated
| Borg only supports archives up to a certain size. The size of an archive | ||
| relative to this limit depends on a number of factors, mainly the number | ||
| of files, the lengths of paths and other metadata stored for files. | ||
| This is shown as *utilization of maximum possible archive size*. |
There was a problem hiding this comment.
also update here if you change above.
src/borg/archiver.py
Outdated
| If you copy a repository with the lock held, the lock will be present in | ||
| the copy, obviously. Thus, before using borg on the copy, you need to | ||
| use "borg break-lock" on it. | ||
| the copy. Thus, before using borg on the copy from or on a different host, |
There was a problem hiding this comment.
not sure about what "from or on" shall mean here.
if you run the client "from" a machine, it means the same as if you run the client "on" a machine.
src/borg/archiver.py
Outdated
| use "borg break-lock" on it. | ||
| the copy. Thus, before using borg on the copy from or on a different host, | ||
| you need to use "borg break-lock" on it. | ||
| (Borg is cautious and does not automatically remove stale locks made by a different host) |
There was a problem hiding this comment.
remove parens, add dot?
or move it to before the final dot of previous sentence?
3 participants
Fixes #2869
Fixes #2868