make bsdflags linux code fd-based#3961
Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom Jul 7, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3961 +/- ##
========================================
- Coverage 85.2% 85.1% -0.1%
========================================
Files 37 37
Lines 9185 9185
Branches 1527 1527
========================================
- Hits 7826 7817 -9
- Misses 923 930 +7
- Partials 436 438 +2
Continue to review full report at Codecov.
|
ThomasWaldmann
force-pushed
the
flags-fd-based
branch
from
642f357 to
09abe59
Compare
This was referenced Jul 7, 2018
this optimization is only needed for linux, the bsd-like platforms do not need an open file to run a ioctl against, but have bsdflags in the stat result already. on linux, this optimization saves 1 file open/close per input file.
ThomasWaldmann
force-pushed
the
flags-fd-based
branch
from
09abe59 to
018b62c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on PR #3960.