Skip to content

declare "allow_cache_wipe" marker in pytest.ini to avoid pytest warning#5197

Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
FelixSchwarz:pytest-warning
Jun 2, 2020
Merged

declare "allow_cache_wipe" marker in pytest.ini to avoid pytest warning#5197
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
FelixSchwarz:pytest-warning

Conversation

@FelixSchwarz
Copy link
Contributor

Undeclared markers trigger a pytest warning:
PytestUnknownMarkWarning: Unknown pytest.mark.allow_cache_wipe - is this a typo?

You can see the warning in the current travis output:

=============================== warnings summary ===============================

.tox/py38/lib/python3.8/site-packages/borg/testsuite/archiver.py:1726

  /home/travis/build/borgbackup/borg/.tox/py38/lib/python3.8/site-packages/borg/testsuite/archiver.py:1726: PytestUnknownMarkWarning: Unknown pytest.mark.allow_cache_wipe - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/latest/mark.html

    @pytest.mark.allow_cache_wipe

-- Docs: https://docs.pytest.org/en/latest/warnings.html

@ThomasWaldmann
Copy link
Member

travis-ci looks rather unhappy somehow.

@ThomasWaldmann
Copy link
Member

this does not run any tests any more.

@ThomasWaldmann
Copy link
Member

guess moving this to the pytest section in setup.cfg would fix it.

Undeclared markers trigger a pytest warning:

    PytestUnknownMarkWarning: Unknown pytest.mark.allow_cache_wipe - is this a typo?
@FelixSchwarz
Copy link
Contributor Author

@ThomasWaldmann sorry for just dumping this PR. Your guess was correct. I pushed an updated version of this commit.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #5197 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5197      +/-   ##
==========================================
- Coverage   84.06%   83.90%   -0.17%     
==========================================
  Files          37       37              
  Lines        9836     9836              
  Branches     1638     1638              
==========================================
- Hits         8269     8253      -16     
- Misses       1090     1103      +13     
- Partials      477      480       +3     
Impacted Files Coverage Δ
src/borg/archive.py 82.76% <0.00%> (-0.62%) ⬇️
src/borg/archiver.py 81.03% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b1c47...3f68f40. Read the comment docs.

@ThomasWaldmann ThomasWaldmann merged commit b504d3d into borgbackup:master Jun 2, 2020
@ThomasWaldmann
Copy link
Member

guess this is also needed for 1.1-maint?

@FelixSchwarz
Copy link
Contributor Author

guess this is also needed for 1.1-maint?

Well, the problem also applies to 1.1.x but for me it is not important to fix because it is just a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants