Skip to content

Support repositories in fish tab completion#5256

Merged
ThomasWaldmann merged 3 commits intoborgbackup:masterfrom
SanskritFritz:master
Jul 31, 2020
Merged

Support repositories in fish tab completion#5256
ThomasWaldmann merged 3 commits intoborgbackup:masterfrom
SanskritFritz:master

Conversation

@SanskritFritz
Copy link
Contributor

Now that soon we'll have awesome zsh completions, it is time to make fish completions more awesome.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2020

Codecov Report

Merging #5256 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5256      +/-   ##
==========================================
- Coverage   83.75%   83.65%   -0.11%     
==========================================
  Files          37       37              
  Lines        9789     9953     +164     
  Branches     1622     1655      +33     
==========================================
+ Hits         8199     8326     +127     
- Misses       1113     1144      +31     
- Partials      477      483       +6     
Impacted Files Coverage Δ
src/borg/helpers/process.py 65.43% <0.00%> (-13.47%) ⬇️
src/borg/helpers/msgpack.py 84.90% <0.00%> (-2.72%) ⬇️
src/borg/helpers/parseformat.py 89.00% <0.00%> (-1.36%) ⬇️
src/borg/helpers/fs.py 86.66% <0.00%> (-1.01%) ⬇️
src/borg/repository.py 84.04% <0.00%> (-0.29%) ⬇️
src/borg/crypto/keymanager.py 91.01% <0.00%> (-0.16%) ⬇️
src/borg/remote.py 79.83% <0.00%> (-0.04%) ⬇️
src/borg/archiver.py 81.27% <0.00%> (-0.02%) ⬇️
src/borg/constants.py 100.00% <0.00%> (ø)
src/borg/helpers/errors.py 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c89cd...f96b9a1. Read the comment docs.

@ThomasWaldmann
Copy link
Member

similar here: can we have a better commit comment?

i guess it can now complete archives by looking into the repo.
does it also complete repos if they are local dirs? but not if they are remote ssh:// repos, right?

@SanskritFritz
Copy link
Contributor Author

Completing archives was already supported. This rewrite allows completion of local directories as repositories and offers ssh hosts as possible remote locations.
How do I change the commit comment?

@ThomasWaldmann
Copy link
Member

I usually use something like git rebase -i BASEBRANCH to do all sorts of changes, including rewording of commit comments.

@SanskritFritz
Copy link
Contributor Author

I don't know if that is OK now, there are 3 commits now o_O
I can start it all over if you want to.

@ThomasWaldmann ThomasWaldmann merged commit 8b30a76 into borgbackup:master Jul 31, 2020
@ThomasWaldmann
Copy link
Member

I've squashed the commits together, thanks!

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Sep 24, 2020

Added a backport to 1.1-maint label here, as discussed in #5255. Be careful, that is stable branch,

@ThomasWaldmann
Copy link
Member

guess this is one of the last pieces missing for 1.1.14.

@SanskritFritz
Copy link
Contributor Author

Sorry I misunderstood you earlier, I thought you did the backport. Hang on, I'm on it, just a little later today.

@ThomasWaldmann
Copy link
Member

Would be great if you could do it, I am not familiar with the completion stuff.

ThomasWaldmann added a commit that referenced this pull request Sep 28, 2020
Support repositories in fish tab completion (#5256)
@ghost ghost mentioned this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants