Skip to content

Add ssh-agent pull backup method to doc#5288

Merged
ThomasWaldmann merged 6 commits intoborgbackup:masterfrom
tombyman:add-ssh-agent-pull-mode
Sep 25, 2020
Merged

Add ssh-agent pull backup method to doc#5288
ThomasWaldmann merged 6 commits intoborgbackup:masterfrom
tombyman:add-ssh-agent-pull-mode

Conversation

@tombyman
Copy link
Contributor

@tombyman tombyman commented Aug 7, 2020

[DOCS] Add ssh-agent pull mode
Closes #5287 .

@tombyman tombyman mentioned this pull request Aug 7, 2020
Closed
ThomasWaldmann
ThomasWaldmann reviewed Aug 7, 2020
View reviewed changes
Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks simple and straightforward, thanks for suggesting this!

i noticed some grammar issues, i can fix them before merging and after the other issues are fixed.

@tombyman
Copy link
Contributor Author

tombyman commented Aug 11, 2020

Fixed mentioned shortcomings and added some clarifications.

ThomasWaldmann
ThomasWaldmann reviewed Aug 15, 2020
View reviewed changes
@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Aug 20, 2020

Tell me when you're finished with editing / proofreading.

@tombyman
Copy link
Contributor Author

tombyman commented Aug 20, 2020

I have finished.

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Aug 20, 2020

OK, thanks! I'll proofread and do minor fixes then...

@ThomasWaldmann ThomasWaldmann self-assigned this Aug 20, 2020
@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Sep 22, 2020

@tombyman see review / please proofread.

ThomasWaldmann
ThomasWaldmann reviewed Sep 22, 2020
View reviewed changes
@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Sep 23, 2020

As most people use 1.1.x and read 1.1.x docs, a backport of this to 1.1-maint (after merging into master) seems advisable.

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Sep 23, 2020

@tombyman ping :-)

@ThomasWaldmann ThomasWaldmann added this to the 1.1.14 milestone Sep 23, 2020
ThomasWaldmann
ThomasWaldmann reviewed Sep 25, 2020
View reviewed changes
Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating!

one small fix and we're ready to merge into master.

@ThomasWaldmann ThomasWaldmann merged commit aef5e89 into borgbackup:master Sep 25, 2020
@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Sep 25, 2020

Thanks! I squashed the commits together, so it is easier to backport.

Would you like to do the backport to 1.1-maint branch?

@tombyman
Copy link
Contributor Author

tombyman commented Sep 26, 2020

Thanks! I squashed the commits together, so it is easier to backport.

Would you like to do the backport to 1.1-maint branch?

Yes.
I have no much experience in such workflow so it can take some time.

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Sep 26, 2020

IIRC, we have something about it in our developer docs. Search for cherry-pick.

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Sep 27, 2020

guess this is one of the last pieces missing for 1.1.14.

tombyman added a commit to tombyman/borg that referenced this pull request Oct 1, 2020
@tombyman @ThomasWaldmann
Add ssh-agent pull backup method to doc (borgbackup#5288)
bcee4f4 
deployment docs: add ssh-agent pull backup method

Co-authored-by: Король Алексей <a.korol@npp-crts.ru> (main work)
Co-authored-by: Thomas Waldmann <tw@waldmann-edv.de>
(cherry picked from commit aef5e89)
tombyman added a commit to tombyman/borg that referenced this pull request Oct 1, 2020
@tombyman @ThomasWaldmann
Add ssh-agent pull backup method to doc (borgbackup#5288)
c9a6fe0 
deployment docs: add ssh-agent pull backup method

Co-authored-by: Король Алексей <a.korol@npp-crts.ru> (main work)
Co-authored-by: Thomas Waldmann <tw@waldmann-edv.de>
(cherry picked from commit aef5e89)
@tombyman tombyman mentioned this pull request Oct 1, 2020
Merged
@ThomasWaldmann ThomasWaldmann removed this from the 1.1.14 milestone Oct 1, 2020
ThomasWaldmann added a commit that referenced this pull request Oct 1, 2020
@ThomasWaldmann
Merge pull request #5369 from tombyman/backport-to-1.1-maint
328b180 
Add ssh-agent pull backup method to docs (#5288)
@tombyman tombyman deleted the add-ssh-agent-pull-mode branch October 1, 2020 12:26
@anarcat anarcat mentioned this pull request Nov 3, 2020
Closed
@ghost ghost mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomasWaldmann ThomasWaldmann ThomasWaldmann left review comments

Assignees

@ThomasWaldmann ThomasWaldmann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document how to use ssh-agent pull mode

2 participants

@tombyman @ThomasWaldmann