enable using libxxhash (1.1-maint only)#5404
Merged
ThomasWaldmann merged 4 commits intoborgbackup:1.1-maintfrom Oct 10, 2020
Merged
enable using libxxhash (1.1-maint only)#5404ThomasWaldmann merged 4 commits intoborgbackup:1.1-maintfrom
ThomasWaldmann merged 4 commits intoborgbackup:1.1-maintfrom
Conversation
Author: Gianfranco Costamagna <locutusofborg@debian.org>
Codecov Report
@@ Coverage Diff @@
## 1.1-maint #5404 +/- ##
=============================================
+ Coverage 79.52% 80.25% +0.73%
=============================================
Files 27 27
Lines 10359 10359
Branches 1827 1827
=============================================
+ Hits 8238 8314 +76
+ Misses 1603 1532 -71
+ Partials 518 513 -5
Continue to review full report at Codecov.
|
i tested it with libxxhash 0.6.5 on debian buster [amd64], it worked. but for ARM it requires an important fix that was released in 0.7.2.
when including .h (as usual), one runs into this:
building 'borg.algorithms.checksums' extension
gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/home/user/w/borg-env/include -I/home/user/.pyenv/versions/3.5.3/include/python3.5m -c src/borg/algorithms/checksums.c -o build/temp.linux-x86_64-3.5/src/borg/algorithms/checksums.o
src/borg/algorithms/checksums.c:838:17: error: field ‘state’ has incomplete type
XXH64_state_t state;
^~~~~
when including .c, it works!
ThomasWaldmann
force-pushed
the
libxxh-1.1
branch
from
da16605 to
40fb6b3
Compare
Member
Author
|
@LocutusOfBorg i did some testing on misc. OSes and dists and think this is ready to merge. What do you think? |
Member
Author
|
https://buildd.debian.org/status/package.php?p=borgbackup&suite=sid looks good, merging... |
Contributor
|
yay thanks a lot!!! |
Contributor
|
Also ppa for xenial, bionic, focal and groovy are good now |
This was referenced Oct 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to the code we already have in master branch.
thanks to @LocutusOfBorg !
fixes #5400.