Fix spurious failure in test_cache_files#5479
Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom Nov 3, 2020
Merged
Fix spurious failure in test_cache_files#5479ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
Conversation
Member
|
Hah, so easy, once you see it. :-) |
Member
|
Please also check if a backport is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5438. The issue here was kind of funny. I ran the tests 1000 times, and they failed 4 - very close to 1/256th of the time. Then the problem became obvious: the corrupt() function wasn't corrupting the cache file if it did in fact originally end in "1".