Use --timestamp in placeholders if given (1.1 backport)#5488
Merged
ThomasWaldmann merged 3 commits intoborgbackup:1.1-maintfrom Nov 6, 2020
Merged
Use --timestamp in placeholders if given (1.1 backport)#5488ThomasWaldmann merged 3 commits intoborgbackup:1.1-maintfrom
ThomasWaldmann merged 3 commits intoborgbackup:1.1-maintfrom
Conversation
Member
|
py35 tests failing. |
Contributor
Author
|
Ah, this is because astimezone only works on naive objects as of 3.6. Is there a good reason --timestamp is limited to UTC in the first place? Currently the timestamp, whether given directly or via a file, is a naive datetime. IMO the "best" way to solve this issue is to make them timezone aware. |
Merged
Member
|
I can't help with that, please find out in the code yourself. I just want it to be consistent, so implement dealing with timezones in the same way as the code is doing it right now. |
Contributor
Author
|
I was mostly thinking out loud. TL;DR it works correctly, such that {now} is different from {utcnow} with --timestamp (if you're not in UTC timezone). |
Member
|
Thanks for the PR. For remaining issues / ideas, please open a ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5189, #5472.