Skip to content

Show date of next backup#1319

Merged
m3nu merged 5 commits into
borgbase:masterfrom
tal66:next-backup
May 29, 2022
Merged

Show date of next backup#1319
m3nu merged 5 commits into
borgbase:masterfrom
tal66:next-backup

Conversation

@tal66
Copy link
Copy Markdown
Contributor

@tal66 tal66 commented May 24, 2022

Hi, this closes #1315.

changed this function a bit, if you prefer the way it was before just leave the last few lines.

Comment thread src/vorta/scheduler.py
Comment thread src/vorta/scheduler.py Outdated
@borgbase borgbase deleted a comment from tal66 May 25, 2022
Comment thread src/vorta/scheduler.py Outdated
Comment thread src/vorta/scheduler.py Outdated
tal66 and others added 2 commits May 25, 2022 16:07
Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
@real-yfprojects
Copy link
Copy Markdown
Collaborator

I rebased through the github ui.

@real-yfprojects real-yfprojects self-requested a review May 25, 2022 16:10
Copy link
Copy Markdown
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. However, the contextmenu of the tray icon gets quite large through displaying Next Task: dd/mm/yyyy HH:MM.

@real-yfprojects real-yfprojects requested a review from m3nu May 25, 2022 16:13
@m3nu
Copy link
Copy Markdown
Contributor

m3nu commented May 26, 2022

Works as advertised. However, the contextmenu of the tray icon gets quite large through displaying Next Task: dd/mm/yyyy HH:MM.

How about removing the year, using a less ambiguous date format and 24h format (or the local preference, if any)? Like May 24, 15:30. Hope you guys don't tell me the next backup could be next year and hence we need to keep the year. 😄

Size isn't too terrible:

Screen Shot 2022-05-26 at 07 29 54

@real-yfprojects
Copy link
Copy Markdown
Collaborator

May 24, 15:30

This is a good format since month and day cannot be confused. This is a problem with formats like 05/09/22 or 09/05/22.

@tal66
Copy link
Copy Markdown
Contributor Author

tal66 commented May 28, 2022

changed it what your colleague suggested ('May 28, 16:00'). there’s no need for extra imports. let’s close this

Copy link
Copy Markdown
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and also localised!

@m3nu m3nu merged commit 422ca7f into borgbase:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Systemtray context menu shows only time of next backup but ignores the date.

3 participants