Conversation
|
Albert Folch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Deploying interface with
|
| Latest commit: |
4641967
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://834e5082.interface-a9d.pages.dev |
| Branch Preview URL: | https://new-homepage-design.interface-a9d.pages.dev |
|
border is squared in products cards but not in collections and the corners are white actually |
|
why 3 lines in collections card if there are only 2 when they are loaded? |
|
if price is displayed like 12e232 then it means it's a number being converted to a string, you should use format/parseUnits from ethers |
|
images overflow parent container |
| position: relative; | ||
| padding-bottom: 7.8125rem; | ||
| background: ${colors.lightGrey}; | ||
| background: #f5f5f5; |
There was a problem hiding this comment.
can you use the color from colors or add it there as a new color if it's not there?
| useEffect(() => { | ||
| const loadImages = async () => { | ||
| const resolvedUrls = images.map((url) => | ||
| resolveUrlFromIPFS(url, "https://ipfs.io/ipfs") |
There was a problem hiding this comment.
use CONFIG.ipfsImageGateway
src/pages/landing/Landing.tsx
Outdated
| const TitleAndDescriptionWrapper = withUnderBanner ? Layout : Div; | ||
| const LayoutWrapper = isSideNavBar ? Grid : DarkerBackground; | ||
|
|
||
| const numOffers = 10; |
There was a problem hiding this comment.
move out of Landing() function declaration
src/pages/landing/Landing.tsx
Outdated
| alignItems="flex-end" | ||
| margin="1rem 0 2rem 0" | ||
| > | ||
| <Title tag="h3" style={{ margin: "0" }}> |
There was a problem hiding this comment.
| <Title tag="h3" style={{ margin: "0" }}> | |
| <Title tag="h3" margin={0}> |
…l/interface into new-homepage-design
| price={ | ||
| /e/i.test(String(Number(price?.price || 0))) | ||
| ? Number(price?.price || 0).toFixed(10) | ||
| : (price?.price ?? 0).toString() | ||
| } |
There was a problem hiding this comment.
I think it should be like this
| price={ | |
| /e/i.test(String(Number(price?.price || 0))) | |
| ? Number(price?.price || 0).toFixed(10) | |
| : (price?.price ?? 0).toString() | |
| } | |
| price={price?.price} |
|
|
||
| const LoadingContainer = styled(Grid)` | ||
| height: 100%; | ||
| font-size: 18px; |
src/pages/landing/FeaturedOffers.tsx
Outdated
| margin-left: 1.5rem; | ||
| font-size: 0.875rem; | ||
| font-weight: 600; | ||
| margin-bottom: 1px; |
There was a problem hiding this comment.
change cursor to pointer so the user knows it's clickable
There was a problem hiding this comment.
seller avatar images are not loading
|
can you make the background of the loading spinner fill the entire width (or all except margins)? |
4 participants
No description provided.