Skip to content

Conversation

@theofidry
Copy link
Member

@theofidry theofidry commented Dec 9, 2023

  • Leverage a new class RequirementsBuilder to facilitate the collection of the requirements, making the collecting code more readable.
  • Add unique checks and sorting to the builder to stabilize the output
  • Fix the computed requirements when both the composer.json and composer.lock are found

This PR is not ideal in the sense that it combines a refactoring with an improvement and a fix, but unfortunately the offending code is too hard to deal with to make it worth to split the work any further.

theofidry added a commit to theofidry/box that referenced this pull request Dec 13, 2023
@theofidry theofidry changed the title WIP: refactor requirement checker feat: Improve the requirement checker detection Dec 13, 2023
@theofidry theofidry marked this pull request as ready for review December 13, 2023 21:11
@theofidry theofidry merged commit 98bc2b1 into box-project:main Dec 13, 2023
@theofidry theofidry deleted the refactor/requirements branch December 13, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant