refactor(common): convert header to TypeScript #3962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
tjuanitas
reviewed
Feb 27, 2025
src/elements/common/header/Logo.tsx
Outdated
| import './Logo.scss'; | ||
|
|
||
| export interface LogoProps { | ||
| isSmall?: boolean; |
Contributor
There was a problem hiding this comment.
the isSmall prop is not used in this component. Please remove it in this file and in the component that passes this prop.
tjuanitas
reviewed
Feb 27, 2025
Comment on lines
3
to
5
| import Logo from './Logo'; | ||
| import messages from '../messages'; | ||
| import { VIEW_FOLDER, VIEW_SEARCH } from '../../../constants'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import Logo from './Logo'; | |
| import messages from '../messages'; | |
| import { VIEW_FOLDER, VIEW_SEARCH } from '../../../constants'; | |
| import Logo from './Logo'; | |
| import { VIEW_FOLDER, VIEW_SEARCH } from '../../../constants'; | |
| import messages from '../messages'; |
tjuanitas
reviewed
Feb 27, 2025
| @@ -0,0 +1,46 @@ | |||
| import * as React from 'react'; | |||
| import { injectIntl, type IntlShape } from 'react-intl'; | |||
Contributor
There was a problem hiding this comment.
use useIntl instead of injectIntl
Contributor
Author
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript Migration: Header Component
This PR converts the header component in
src/elements/common/headerfrom JavaScript with Flow to TypeScript.Changes
Header.jstoHeader.tsxLogo.jstoLogo.tsxindex.jstoindex.ts.js.flowfiles for backward compatibilityTesting
References
Link to Devin run: https://app.devin.ai/sessions/ec24228ded1945609fc10152e1c1b056