pytest 4.1 compatibility#140
Conversation
|
Hi @gaborbernat, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks! |
|
CLA signed |
|
Verified that @gaborbernat has just signed the CLA. Thanks, and we look forward to your contribution. |
|
@Jeff-Meadows can we do a quick release with this? |
|
please ensure correct version pins, else this breaks on older pytest versions |
|
flaky does not have any references to pytest, just implicitly. I suppose we could have an if/else to keep the old for older versions. Can we use |
|
|
|
@RonnyPfannschmidt changed. |
| hookname = "pytest_runtest_" + when | ||
| ihook = getattr(item.ihook, hookname) | ||
| call_info = CallInfo( | ||
| call_info = getattr(CallInfo, "from_call", CallInfo)( |
There was a problem hiding this comment.
lets add a link to the pr changing the internal api for later comprehension here
Resolves #139.