on OSX, "Ctrl" prefix for shortcuts doesn't work

[alvint]

When I add a Git shortcut that uses "Ctrl", it doesn't work properly. More precisely, shortcuts defined using Ctrl use Cmd instead, and shortcuts which use both Ctrl and Cmd (like Ctrl-Cmd-K) don't work.

The preferences seem to be correct in the config file, so the issue may lie with Brackets itself.

---

Brackets 1.0.0-15191 (mac), Git 1.9.3 (Apple Git-50) & Brackets-Git 0.14.4

[zaggino]

@alvint Brackets-Git does nothing to the shortcuts, you need to check with main Brackets project about using them. Here are the defaults for Brackets saved:

https://github.com/adobe/brackets/blob/master/src/base-config/keyboard.json

From what I see Cmd-Ctrl combinations should work fine:

{
            "key": "Cmd-Ctrl-Down",
            "displayKey": "Cmd-Ctrl-↓",
            "platform": "mac"
        }

[alvint]

Very odd--it's only the Git shortcuts that I assign in the git panel that have this problem. For example, when I assign the git panel to "Ctrl-Alt-X", it appears to show up properly in my brackets.json file:

        "brackets-git.panelShortcut": "Ctrl-Alt-X",

...but when Brackets loads the shortcut is instead assigned to "Cmd-Alt-X", even if there are no conflicts with "Ctrl-Alt-X" (I can verify this by using the Display Shortcuts extension). If I instead add the shortcut to the keymap.json file:

{
    "documentation": "https://github.com/adobe/brackets/wiki/User-Key-Bindings",
    "overrides": {
        "Ctrl-Alt-X": "brackets-git.panel"
    }
}

...the shortcut works as it should. Judging from this I would guess the problem lies with whatever code reads the Brackets-git shortcuts stored in the brackets.json file and assigns the shortcuts it finds there.

Since later versions of Brackets now has a keymap.json file, why not place the shortcuts in that file and bypass the headache of assigning the shortcuts yourself?

[alvint]

Due to the above, I don't think this is invalid.

[alvint]

Looking at the code you're right; not a lot can go wrong on your end. Maybe addBinding needs the platform parameter on OS X? Otherwise the issue lies with Brackets.

[zaggino]

You're right @alvint , see here: https://github.com/adobe/brackets/blob/master/src/command/KeyBindingManager.js#L643-L644

I will fix this by specifying the platform and it shouldn't replace Ctrl with Cmd anymore.

[zaggino]

Brackets Git updated to version 0.14.8. Please confirm this has been fixed.

[alvint]

Wow, that was fast! Thanks! A most excellent plugin, BTW.

[alvint]

And Brackets needs to document that better. I checked out the API for addBinding and its description of the platform argument is unclear at best.

[zaggino]

@alvint Opened a PR with Brackets, link above.