add Intersect() to compute the intersection of multiple slices#7
Open
ndrpnt wants to merge 1 commit intobradenaw:mainfrom
Open
add Intersect() to compute the intersection of multiple slices#7ndrpnt wants to merge 1 commit intobradenaw:mainfrom
ndrpnt wants to merge 1 commit intobradenaw:mainfrom
Conversation
Owner
|
Interesting. What was your use of this? For what it's worth, you could make this a bit more efficient by using two |
Author
|
For a given user, I had some (short) lists of permissions and resources, e.g. {
{
"permission": "read",
"resources": ["foo", "bar", "baz"]
},
{
"permission": "write",
"resources": ["bar", "baz"]
},
...
}and needed to compute the list of resources for which the user has both read and write permissions. In the end I went with a naive/obvious O(n^2) implementation. 🙈 Later on I stumbled upon your library and thought I'd write something better for fun and contribute it. Thanks for the optimization btw, should I update the PR with it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I needed to compute the intersection of several slices. Algorithm is probably not optimal, but I thought that might interest you nonetheless.
Feel free to reword, rename, add an
IntersectFunc[T comparable](eq func(T, T) bool, in ...[]T) []Tvariant…