Skip to content

fix: scrub email addresses from .squad/ files during migration#122

Merged
bradygaster merged 1 commit intodevfrom
squad/108-email-scrub-migration
Feb 20, 2026
Merged

fix: scrub email addresses from .squad/ files during migration#122
bradygaster merged 1 commit intodevfrom
squad/108-email-scrub-migration

Conversation

@bradygaster
Copy link
Copy Markdown
Owner

Fixes #108

  • Add email scrubbing step to squad upgrade --migrate-directory
  • Add email scrubbing to regular upgrade path (both early-exit and normal completion)
  • Add test coverage for email scrubbing in migration and upgrade scenarios

The existing scrubEmailsFromDirectory() function is now called automatically during:

  1. Migration (squad upgrade --migrate-directory)
  2. Regular upgrade when already up to date
  3. Regular upgrade when updating to new version

Tested with 3 scenarios:

  • Migration with emails present
  • Upgrade with emails present
  • Upgrade with no emails (graceful handling)

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster bradygaster merged commit 575aed1 into dev Feb 20, 2026
1 check passed
@bradygaster bradygaster deleted the squad/108-email-scrub-migration branch February 27, 2026 01:08
joniba pushed a commit to joniba/squad that referenced this pull request Mar 26, 2026
…ster#115) (bradygaster#122)

Phase 1.1: Webhook & message templates for Teams notifications. Implements 3-tier notification router (urgent/action/feature) with Adaptive Cards, watermark-based dedup, exponential backoff retry, and 22 Pester tests. Closes bradygaster#115.
joniba pushed a commit to joniba/squad that referenced this pull request Mar 26, 2026
….md and failure-recovery

R1: Rename proactive-notifications.md → human-attention-notifications.md
    to match what issue bradygaster#112 specifies as the deliverable filename.

R6: Update SKILL.md to document BOTH notification systems:
    - Old system (send-teams-notification.ps1): active, 2 callers
    - New system (notify.ps1): built, 0 callers yet
    Note: old system stays active until MVP is validated.

R7: Update failure-recovery.md notification section to specify:
    - Current: use send-teams-notification.ps1 (old system)
    - Target: switch to notify-blocked.ps1 after E2E validation (bradygaster#135)
    - Explicit migration path instead of ambiguous "post to webhook"

GitHub issue actions (not in this commit):
- Closed bradygaster#115 (library code done in PR bradygaster#122)
- Updated bradygaster#116 body (clarify integration work remains)
- Labeled bradygaster#117 P3-low + scope decision comments (post-MVP)
- Created MVP issues bradygaster#132-bradygaster#135 (caller scripts + wiring + validation)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry added a commit that referenced this pull request Mar 31, 2026
Add concurrency blocks to squad-ci, squad-heartbeat, squad-triage,
squad-issue-assign, and squad-label-enforce workflows across all
template locations. Issue-triggered workflows use per-issue concurrency
groups to prevent cross-issue cancellation.

Closes #122

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@diberry
Copy link
Copy Markdown
Collaborator

diberry commented Mar 31, 2026

🔄 Ralph status update: PR cleaned (1 commit, 26 files), all CI green, all team reviews posted. Labeled \squad:pr-reviewed. Awaiting Dina review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy: Scrub email addresses from .squad/ files during migration

2 participants