fix: only install Squad-framework workflows during init#203
Merged
bradygaster merged 7 commits intobradygaster:devfrom Mar 5, 2026
Merged
Conversation
Squad's own CI/CD workflows (squad-ci, squad-release, squad-docs, etc.) hardcode Squad's branch strategy and Node.js toolchain. They have no business in a user's repository. Add FRAMEWORK_WORKFLOWS constant and filter the workflow copy loop to only install the four workflows that power Squad features: - squad-heartbeat.yml - squad-issue-assign.yml - squad-triage.yml - sync-squad-labels.yml All other workflows in templates/workflows/ are Squad product CI/CD and are no longer installed into user repos. Closes bradygaster#201
Session: 2026-03-05T10-35-50Z-validation-review Requested by: Scribe (session handler) Changes: - Orchestration logs: 4 agent reviews (Keaton, Fenster, Hockney, Edie) - Session log: Validation review summary, ready to merge - Decisions merged: Framework/scaffolding pattern, implementation, test coverage gaps, TypeScript validation - Cross-agent updates: Appended to Keaton, Fenster, Hockney, Edie history.md All agents APPROVED. Merge ready.
Session: 2026-03-05T10-39-25Z-test-coverage-fix Requested by: Scribe Changes: - Merged decision: Testing Lessons from Migrate Command (Hockney) — lifecycle tests, boundary testing, security test blocks, recovery tests - Merged decision: QA Discipline for Destructive Commands (Waingro) — file ownership matrix, gherkin scenarios, pre-flight checklist, shell state tests, version-specific fixtures - Deleted inbox files: hockney-migrate-test-gaps.md, waingro-destructive-qa-discipline.md - Logged orchestration: Hockney (test verification), Kobayashi (issue documentation) - Updated Hockney's history with team decision Both decisions establish mandatory test patterns for CLI commands that modify .squad/ or perform destructive operations.
Remove ephemeral session attribution (requester usernames, branch names) from agent history.md files. History should capture reusable knowledge, not session metadata. Also clarifies history.md writing guidance in squad.agent.md spawn template to prevent recurrence.
.squad/config.json is written by 'squad link' and 'squad init --remote' for remote team mode. The teamRoot field is an absolute local path and must not be committed. Add to .gitignore to prevent accidental inclusion.
tmcclell
pushed a commit
to tmcclell/squad
that referenced
this pull request
Mar 5, 2026
…tes (bradygaster#185, bradygaster#188, bradygaster#191, bradygaster#192, bradygaster#195, bradygaster#196, bradygaster#199, bradygaster#201, bradygaster#203, bradygaster#206, bradygaster#207) Documentation Epic bradygaster#182 — complete: Docs Content (McManus): - Architecture overview: SDK ↔ CLI ↔ SquadUI system design - Migration guide: Beta → v1 with 10-step checklist - Global CLI install guide: npm, npx, GitHub native - VS Code integration guide: client compatibility, extension patterns - SDK API reference: 574 lines, all 30+ exports documented Docs Site Engine (Keaton): - Static site generator: node docs/build.js → docs/dist/ - GitHub Pages ready, responsive design, sidebar nav - Index landing page linking all guides Mechanical Updates (Fenster): - .ai-team/ → .squad/ across 25 doc files (bradygaster#191) - CLI invocation references verified current (bradygaster#192) - Beta repo URLs updated to squad-pr (bradygaster#195) Docs Tests (Hockney): - 17 docs validation tests: headings, code blocks, links, build - Fixed link checker for parent-dir refs, Windows rmSync Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster
added a commit
that referenced
this pull request
Mar 5, 2026
Session: 2026-03-05T21:05Z-release-planning Requested by: Copilot (Scribe role) Changes: - Logged orchestration entries for Keaton, McManus, Kobayashi, Fenster, Coordinator - Created session log documenting v0.8.21 release planning outcomes - Merged 3 decision inbox files into decisions.md - Deleted inbox files (contributor page, PR merges, user directives) Decision Merged: - Every release MUST include contributor page update - Workstreams MUST be included in v0.8.21 Outcomes documented: - 4 PRs merged to dev (#204, #203, #198, #189) - 2 issues fixed (#210, #195) - Build passing, 98.8% test coverage - Release scope: 18 unreleased commits
williamhallatt
deleted the
williamhallatt/201-investigate-actions-install
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #201
Restricts workflow installation during
squad initto only the 4 Squad-framework workflows that power Squad features in user repositories, excluding the 8 Squad-product CI/CD pipeline workflows that belong only in the Squad repository itself.What changed
FRAMEWORK_WORKFLOWSconstant inpackages/squad-sdk/src/config/init.ts.squad/config.jsonadded to.gitignore— this file contains a machine-localteamRootabsolute path written bysquad link/squad init --remote. It must never be committed. This is a manual patch for this branch; the programmatic fix (auto-add onsquad link/squad init --remote) is tracked in squad link / squad init --remote should auto-add .squad/config.json to .gitignore #202..github/agents/squad.agent.md— AFTER work section updated with an explicit "DO NOT record: requester names, branch names, session metadata" rule. This prevents agents from writing session attribution intohistory.mdfiles. Addresses the root cause of the metadata found during review of PR fix(migrate): automated migration experience for v0.5.4 → v0.8.x #199.Known gap
squad upgradestill restores all 12 workflows for existing users via the templates manifest (packages/squad-cli/src/cli/core/templates.ts). Tracked as follow-up in #202.Reviewer notes
dev, no code overlap except the identical.gitignoreline described below.squad.agent.mdspawn template fix that documents the session-metadata anti-pattern discovered during the fix(migrate): automated migration experience for v0.5.4 → v0.8.x #199 review cycle — merging this first gives full context for reviewing fix(migrate): automated migration experience for v0.5.4 → v0.8.x #199..gitignoreoverlap: Both this PR and PR fix(migrate): automated migration experience for v0.5.4 → v0.8.x #199 add the same.squad/config.jsonentry to.gitignore. They are identical additions on independent branches. Whichever merges second will produce a clean no-op (no conflict)..squad/agents/*/history.mdfiles). Both are documented in PR fix(migrate): automated migration experience for v0.5.4 → v0.8.x #199's comments. The spawn template fix in this PR prevents recurrence on all future branches.