fix cli blankspace issue#243
Closed
dkirby-ms wants to merge 9 commits intobradygaster:devfrom
Closed
Conversation
- Register consult and extract commands in cli-entry.ts with help text - Add docs/features/consult-mode.md with full command reference - Update docs/guide/personal-squad.md to reference consult mode - Add happy-path E2E tests (init global → consult → status → extract) - Add acceptance test features for consult and extract commands Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ster#196) runShell() hardcoded teamRoot to process.cwd(), ignoring the global (personal) squad path. Now uses a fallback chain: 1. Walk up from cwd for local .squad/ 2. Check global squad path (resolveGlobalSquadPath) 3. Fall back to cwd (triggers init mode) Closes bradygaster#196 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Feature files referenced old output strings ("Getting Started",
"Here:", "Scaffold ready") that no longer exist in the CLI help,
status, and init output. Updated to match actual output.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix runtime crash by declaring @opentelemetry/api as required dependency
feat: wire up consult mode CLI + fix global squad resolution (bradygaster#196)
The upstream command (add/remove/list/sync) was fully implemented in upstream.ts but never registered in cli-entry.ts. Running 'squad upstream' returned 'Unknown command'. Closes bradygaster#224 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…-wiring fix: wire upstream command into CLI entry point
Owner
|
Hi @dkirby-ms - thanks for this fix! The App.tsx blankspace fix is a solid improvement (conditionally applying height/overflow only when processing). Conflict status after retarget to dev: This PR was retargeted from main to dev (our active development branch). Unfortunately, it now has 4 merge conflicts:
The good news: Your actual App.tsx blankspace fix (components/App.tsx) auto-merges cleanly with no conflicts. That is the valuable part. The root cause of the extra conflicts is that main and dev have diverged - your fork is based on main, so the PR carries main-only commits that conflict with dev. Recommended next step: If you can rebase your branch onto origin/dev (keeping only your fix commit), this should merge cleanly. Alternatively, we can cherry-pick just the App.tsx change on our side. Cannot merge as-is due to the conflicts - leaving this open for resolution. |
bradygaster
added a commit
that referenced
this pull request
Mar 7, 2026
Apply fix from PR #243 (dkirby-ms): only constrain live region height while processing. When idle, auto-size to avoid blank space between the agent panel and the input prompt. Credit: @dkirby-ms Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Hey @dkirby-ms! Great fix — I cherry-picked the App.tsx blankspace fix directly onto dev (commit 3f924d0) and closed #239. The rest of the PR (consult mode docs, test changes) has merge conflicts from dev divergence, so I'm going to close this PR. Your contribution is credited in the commit. Thank you! 🙏 |
jongio
pushed a commit
to jongio/squad
that referenced
this pull request
Mar 9, 2026
…radygaster#242, bradygaster#243, bradygaster#244) * feat: shell UI components — AgentPanel, MessageStream, InputPrompt (bradygaster#242, bradygaster#243, bradygaster#244) Add ink-based React components for the interactive shell: - AgentPanel: displays live agent status with role and status icons - MessageStream: renders streaming output with message history - InputPrompt: readline input with history navigation (up/down arrow) - Barrel export from components/index.ts - Added jsx: react-jsx to tsconfig.json for TSX compilation - Removed components/.gitkeep (replaced by actual components) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: remove --provenance from publish (private repo limitation) npm provenance requires a public source repository. Since squad-pr is private, remove --provenance and id-token: write from both publish workflows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: shell integration tests — lifecycle, spawn, coordinator, sessions (bradygaster#248) Add 47 integration tests for the shell module covering: - SessionRegistry: register, get, getAll, getActive, updateStatus, remove, clear - Spawn: loadAgentCharter, buildAgentPrompt (with/without systemContext) - Coordinator: buildCoordinatorPrompt, parseCoordinatorResponse (DIRECT/ROUTE/MULTI/fallback), formatConversationContext - ShellLifecycle: init, message history, agent discovery, shutdown - StreamBridge: message_delta, usage, reasoning_delta, flush, buffer accumulation, clear Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster
added a commit
that referenced
this pull request
Mar 9, 2026
…roster - Add PR #298 (active nav highlighting, favicon fixes) to blog 028 - Update Squad roster from Usual Suspects to Apollo 13 / Mission Control names - Credit @tamirdresher PRs #272, #278-280, #283 - Credit @IEvangelist PR #298 - Credit @dkirby-ms PR #243 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster
added a commit
that referenced
this pull request
Mar 9, 2026
…roster (#300) - Add PR #298 (active nav highlighting, favicon fixes) to blog 028 - Update Squad roster from Usual Suspects to Apollo 13 / Mission Control names - Credit @tamirdresher PRs #272, #278-280, #283 - Credit @IEvangelist PR #298 - Credit @dkirby-ms PR #243 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster
added a commit
that referenced
this pull request
Mar 9, 2026
- Add David Pine (@IEvangelist) to Code Contributors — PRs #293, #298 - Add Dina Berry (@diberry) to Code Contributors — PRs #286, #288, #290, #292 - Update Tamir Dresher with recent PRs #278-280, #283 - Add Dale Kirby to Code Contributors — PR #243 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster
added a commit
that referenced
this pull request
Mar 9, 2026
* docs(ai-team): session log and orchestration records Session: 2026-03-09-docs-push-contributors Requested by: Brady Changes: - Logged PAO orchestration: blog 028 update, CONTRIBUTORS.md refresh - Logged FIDO orchestration: test baseline verification (22 passing) - Logged session summary: docs push workflow with PR #300 merge - No decisions inbox entries to merge * docs: credit Pine, Dina, Tamir, Kirby on docs contributor page - Add David Pine (@IEvangelist) to Code Contributors — PRs #293, #298 - Add Dina Berry (@diberry) to Code Contributors — PRs #286, #288, #290, #292 - Update Tamir Dresher with recent PRs #278-280, #283 - Add Dale Kirby to Code Contributors — PR #243 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry
pushed a commit
to diberry/squad
that referenced
this pull request
Mar 10, 2026
…ntributors roster (bradygaster#300) - Add PR bradygaster#298 (active nav highlighting, favicon fixes) to blog 028 - Update Squad roster from Usual Suspects to Apollo 13 / Mission Control names - Credit @tamirdresher PRs bradygaster#272, bradygaster#278-280, bradygaster#283 - Credit @IEvangelist PR bradygaster#298 - Credit @dkirby-ms PR bradygaster#243 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry
pushed a commit
to diberry/squad
that referenced
this pull request
Mar 10, 2026
…gaster#307) * docs(ai-team): session log and orchestration records Session: 2026-03-09-docs-push-contributors Requested by: Brady Changes: - Logged PAO orchestration: blog 028 update, CONTRIBUTORS.md refresh - Logged FIDO orchestration: test baseline verification (22 passing) - Logged session summary: docs push workflow with PR bradygaster#300 merge - No decisions inbox entries to merge * docs: credit Pine, Dina, Tamir, Kirby on docs contributor page - Add David Pine (@IEvangelist) to Code Contributors — PRs bradygaster#293, bradygaster#298 - Add Dina Berry (@diberry) to Code Contributors — PRs bradygaster#286, bradygaster#288, bradygaster#290, bradygaster#292 - Update Tamir Dresher with recent PRs bradygaster#278-280, bradygaster#283 - Add Dale Kirby to Code Contributors — PR bradygaster#243 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to address #239. Tested locally and works to remove the blankspace issue I encountered.
I also found another compile-time issue with doubled single quotes which I fixed. Not sure if there was some intention behind that but it didnt build otherwise.