fix: use filename-safe timestamps in log filenames (#348)#406
Closed
bradygaster wants to merge 4 commits intodevfrom
Closed
fix: use filename-safe timestamps in log filenames (#348)#406bradygaster wants to merge 4 commits intodevfrom
bradygaster wants to merge 4 commits intodevfrom
Conversation
Session: 2026-03-15T11-40-00Z-skill-install-and-flicker-fix Requested by: Coordinator Changes: - Appended team updates to Flight history: bug classification (6 issues, 2 fixed) - Appended team updates to PAO history: PR #403 merge (docs FAQ) - Created INCO history: terminal flicker fix cherry-pick to dev (PR #405) - Logged session activity for Flight, PAO, INCO, Coordinator Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Executed full reskill process to reduce per-agent context overhead: **Step 1: Audit** - Audited 20 agent charters (51,163 bytes total) - Audited 12 agent histories (41,915 bytes total) - Identified boilerplate in Collaboration, Boundaries, Voice sections - Identified shared patterns across test discipline, docs standards, Windows compatibility **Step 2: Extract** Created 3 new skills from shared patterns: - test-discipline: Update tests when changing APIs (FIDO/EECOM/PAO patterns) - windows-compatibility: Cross-platform path handling (EECOM/Scribe patterns) - docs-standards: Microsoft Style Guide + Squad conventions (PAO patterns) **Step 3: Trim** Charters trimmed to minimal template (≤1.5KB target): - Removed Collaboration section (now in agent-collaboration skill) - Removed Voice section (tagline blockquote sufficient) - Removed verbose Boundaries boilerplate - Trimmed Model rationale to single line - Removed domain knowledge now in skills Histories trimmed (≤8KB target): - Removed session metadata (dates, branch names, requester names) - Consolidated learnings into Core Context + Patterns sections - Promoted recurring patterns to skills **Savings:** - Charters: 51,163 → 24,503 bytes (26,660 saved, 52.1%) - Histories: 41,915 → 10,560 bytes (31,355 saved, 74.8%) - Total: 93,078 → 35,063 bytes (58,015 saved, 62.3%) Skills extracted: 3 new, 16 existing → 19 total shared knowledge base Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace colons with hyphens in ISO 8601 timestamps used for orchestration-log and session-log filenames. Colons are invalid in Windows filenames, causing git clone failures on Windows. - Update SDK templates (scribe-charter.md, squad.agent.md, orchestration-log.md) to specify filename-safe timestamps - Update root templates with the same fix - Refactor import.ts to use safeTimestamp() instead of inline replace - Add safe-timestamp.test.ts to verify no colons in output Closes #348 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace colons with hyphens in ISO 8601 timestamps used for orchestration-log and session-log filenames. Colons are invalid in Windows filenames, causing
git clonefailures on Windows.Working as EECOM (Core Dev)
Closes #348
Changes
packages/squad-sdk/templates/): Updatedscribe-charter.md,squad.agent.md, andorchestration-log.mdto specify filename-safe timestamps (replace colons with hyphens)templates/): Same fix applied toscribe-charter.md,squad.agent.md, andorchestration-log.mdtoISOString().replace()with the sharedsafeTimestamp()utility from squad-sdkTesting
test/safe-timestamp.test.ts— 5 tests verifying:YYYY-MM-DDTHH-MM-SSZpattern