test: SDK feature parity batch 3 — 46 tests for #31, #47, #45, #46#428
Merged
bradygaster merged 2 commits intobradygaster:devfrom Mar 16, 2026
Merged
Conversation
…er#341) 46 tests covering 4 features: - bradygaster#31 Ralph Idle-Watch Mode (RalphMonitor): 11 tests - bradygaster#47 Client Compatibility (Platform Detection): 16 tests - bradygaster#45 Reviewer Lockout (deepened): 11 tests - bradygaster#46 Deadlock Handling (deepened): 8 tests Combined with batch 1 (PR bradygaster#422) and batch 2 (PR bradygaster#425), automated tests now cover 11 of 13⚠️ Needs Setup features from bradygaster#341.
Owner
|
And batch 3 brings it home — 46 more tests, Ralph idle-watch coverage, platform detection for both GitHub and ADO, plus you went back and deepened the reviewer lockout and deadlock tests from batch 1. Between your two PRs and my batch 1, we now have 132 tests covering 11 of 13 |
tamirdresher
pushed a commit
to tamirdresher/squad
that referenced
this pull request
Mar 16, 2026
…l paths (bradygaster#440) * chore(squad): quality review findings — 7 issues filed Quality audit complete: 5 agents assessed CLI across testing, coverage, stability, accessibility, UX. Results: 4 P0 blockers (bradygaster#365–bradygaster#368), 3 P1 items (bradygaster#369–bradygaster#371). Blocking: Waingro dead sessions, ErrorBoundary, dropped input; Marquez help text consistency. Changes: - Logged session summary to .squad/log/2026-02-24T0205-quality-review-complete.md - Updated .squad/identity/now.md with quality review findings and new issue numbers Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore(squad): merge decision — Marquez UX audit findings Quality assessment merged from inbox (Grade B): 11 improvements (3 P0, 4 P1, 4 P2). help text, stub commands, vocabulary, separators, roster. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix bradygaster#418: Add progress indicator for long operations Show 'Still working... (Xm Ys elapsed)' after 30 seconds, updating every 30 seconds during sendAndWait timeout. Prevents users from thinking the system has hung during long agent operations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix bradygaster#428/bradygaster#401: Add pending input queue for disabled→enabled transition The ref-based buffer from bradygaster#381 handles keystrokes during disabled state, but fast typing during the disabled→enabled transition could race with React's useEffect. Added pendingInputRef queue to catch characters that arrive before the effect drains bufferRef. Edge cases fixed: - Paste events (rapid character arrival) - Fast typing during transition window - Race between useInput and useEffect restoration Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix bradygaster#430: Document and enhance coordinator streaming diagnostics Verified that coordinator message_delta event wiring is correct: - Both dispatchToCoordinator and dispatchToAgent use identical streaming patterns - message_delta listener registered BEFORE awaitStreamedResponse call - CopilotSessionAdapter maps 'message_delta' -> 'assistant.message_delta' correctly - Coordinator session created with streaming: true config Enhanced diagnostics: - Added session creation logging (sessionId, capabilities) - Added listener registration/removal logging - Added fallback path logging to track when sendAndWait content is used - Documented streaming architecture in function comments All 41 streaming tests pass. No functional changes, only diagnostic improvements. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update Kovash history: input buffering fix bradygaster#428/bradygaster#401 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds 46 SDK feature parity tests (batch 3) for the #347 quality gate.
This batch covers features not tested by batch 1 (PR #422) or batch 2 (PR #425), plus deepens partial coverage from batch 1.
Tests (46 total)
RalphMonitorconstruction, event handling (session lifecycle + milestones), stale session detection viahealthCheck(), configurable threshold, cleanupparseGitHubRemote()(HTTPS/SSH),parseAzureDevOpsRemote()(HTTPS/SSH/legacy),detectPlatformFromUrl()(GitHub/ADO/unknown),detectWorkItemSource()(planner override)clearLockout()escalation,clearAll()reset, deadlock recovery (agents work again after clear)Combined⚠️ Feature Coverage (all 3 batches)
2 remaining⚠️ features need integration test infrastructure: #24 (Issue→PR lifecycle) and #32 (Watch mode) — both require
ghCLI mocking.Verification
npm run build✅npm test— 46 passing (4229 total with baseline)tsc --noEmit✅ (lint clean)Contributes to #341, #347.