Skip to content

chore: trim npm package — exclude docs and contributor files#48

Merged
bradygaster merged 2 commits intodevfrom
squad/npmignore-cleanup
Feb 13, 2026
Merged

chore: trim npm package — exclude docs and contributor files#48
bradygaster merged 2 commits intodevfrom
squad/npmignore-cleanup

Conversation

@bradygaster
Copy link
Copy Markdown
Owner

@bradygaster bradygaster commented Feb 13, 2026

What

Trims the published npm package from 82 files / 205.7kB to 30 files / 75.1kB (63% reduction).

Why

Users don't need docs, blog posts, contributor guides, or git config files in
ode_modules. All reference material lives on GitHub.

What a user gets after install

Path Size Purpose
\index.js\ 34.6kB CLI entry point
.github/agents/squad.agent.md\ 107.7kB Coordinator agent
\ emplates/**\ ~63kB Copied into user's repo on \squad init\
\CHANGELOG.md\ 8.9kB Release history
\README.md\ 18.9kB Usage guide (auto-included by npm)
\LICENSE\ 1.1kB MIT license (auto-included by npm)
\package.json\ 0.6kB Metadata (auto-included by npm)

What was excluded

Path Was excluded? Now excluded? Reason
\docs/**\ ❌ No ✅ Yes Reference docs — read on GitHub
\docs/blog/\ ✅ Yes ✅ Yes (via docs/) Blog posts
\CONTRIBUTING.md\ ❌ No ✅ Yes Contributor guide
.gitignore\ ❌ No ✅ Yes Repo config
.ai-team/\ ✅ Yes ✅ Yes Team state
.ai-team-templates/\ ✅ Yes ✅ Yes Internal templates
\ eam-docs/\ ✅ Yes ✅ Yes Internal docs
\ est/\ ✅ Yes ✅ Yes Dev tests

Verification


  • pm pack --dry-run\ confirms 30 files, 75.1kB packed
  • All 45 tests pass
  • \package.json\ \ iles\ field is the allowlist; .npmignore\ is belt-and-suspenders

@bradygaster
chore: unignore .ai-team/ for dev branches, update contributing guide
ebedf74 
- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package
@bradygaster
chore: trim npm package — exclude docs, CONTRIBUTING.md, .gitignore
f0474b8 
- Removed docs/ from package.json files allowlist (read on GitHub, not runtime)
- Added CONTRIBUTING.md, .gitignore, docs/ to .npmignore (belt-and-suspenders)
- Package: 82 files / 205.7kB -> 30 files / 75.1kB (63% smaller)
@bradygaster bradygaster merged commit 5377d41 into dev Feb 13, 2026
1 check passed
bradygaster added a commit that referenced this pull request Feb 13, 2026
@bradygaster
docs: GitHub Pages site with base path support and static template (#53)
3b6bd2d 
* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* chore: trim npm package — exclude docs and contributor files (#48)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* chore: trim npm package — exclude docs, CONTRIBUTING.md, .gitignore

- Removed docs/ from package.json files allowlist (read on GitHub, not runtime)
- Added CONTRIBUTING.md, .gitignore, docs/ to .npmignore (belt-and-suspenders)
- Package: 82 files / 205.7kB -> 30 files / 75.1kB (63% smaller)

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>

* feat: blog migration, team-docs guard, docs site generator (#49, #50, #51) (#52)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* feat: blog migration, team-docs guard, docs site generator (#49, #50, #51)

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>

* fix: add --base path support to docs build for GitHub Pages

Nav links, search index, and logo all used root-relative paths (/index.html)
which 404 on GitHub Pages where the site is served under /squad/.
Added --base CLI flag to build.js and updated workflows to pass --base /squad.
Also added workflow_dispatch trigger for manual re-deploys.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: extract docs template, CSS, and JS into static files

Moved inline HTML template, CSS, and JS from build.js into separate
files under docs/assets/ (template.html, style.css, script.js).
Build script now reads template and does placeholder replacement.
CSS and JS are linked externally via the existing assets copy step.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster added a commit that referenced this pull request Feb 13, 2026
@bradygaster
chore: remove stale team-docs/blog + fix guard for removals (#54)
8935fc3 
* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* chore: trim npm package — exclude docs and contributor files (#48)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* chore: trim npm package — exclude docs, CONTRIBUTING.md, .gitignore

- Removed docs/ from package.json files allowlist (read on GitHub, not runtime)
- Added CONTRIBUTING.md, .gitignore, docs/ to .npmignore (belt-and-suspenders)
- Package: 82 files / 205.7kB -> 30 files / 75.1kB (63% smaller)

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>

* feat: blog migration, team-docs guard, docs site generator (#49, #50, #51) (#52)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* feat: blog migration, team-docs guard, docs site generator (#49, #50, #51)

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>

* fix: add --base path support to docs build for GitHub Pages

Nav links, search index, and logo all used root-relative paths (/index.html)
which 404 on GitHub Pages where the site is served under /squad/.
Added --base CLI flag to build.js and updated workflows to pass --base /squad.
Also added workflow_dispatch trigger for manual re-deploys.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: extract docs template, CSS, and JS into static files

Moved inline HTML template, CSS, and JS from build.js into separate
files under docs/assets/ (template.html, style.css, script.js).
Build script now reads template and does placeholder replacement.
CSS and JS are linked externally via the existing assets copy step.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore: remove stale team-docs/blog from tracking

Blogs already migrated to docs/blog/ — these stale copies predated
the guard workflow update and leaked to main/preview.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: guard workflow should allow removal of forbidden files

The guard was blocking PRs that *delete* team-docs/ or .ai-team/ files
from protected branches. Deletions are exactly what we want — filter
out files with status 'removed' before checking paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster added a commit that referenced this pull request Feb 20, 2026
@spboyer @bradygaster
feat: add 'squad watch' — Ralph local watchdog for persistent polling (…
5ad700e 
…#57)

* docs: GitHub Pages site with base path support and static template (#53)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* chore: trim npm package — exclude docs and contributor files (#48)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* chore: trim npm package — exclude docs, CONTRIBUTING.md, .gitignore

- Removed docs/ from package.json files allowlist (read on GitHub, not runtime)
- Added CONTRIBUTING.md, .gitignore, docs/ to .npmignore (belt-and-suspenders)
- Package: 82 files / 205.7kB -> 30 files / 75.1kB (63% smaller)

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>

* feat: blog migration, team-docs guard, docs site generator (#49, #50, #51) (#52)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* feat: blog migration, team-docs guard, docs site generator (#49, #50, #51)

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>

* fix: add --base path support to docs build for GitHub Pages

Nav links, search index, and logo all used root-relative paths (/index.html)
which 404 on GitHub Pages where the site is served under /squad/.
Added --base CLI flag to build.js and updated workflows to pass --base /squad.
Also added workflow_dispatch trigger for manual re-deploys.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: extract docs template, CSS, and JS into static files

Moved inline HTML template, CSS, and JS from build.js into separate
files under docs/assets/ (template.html, style.css, script.js).
Build script now reads template and does placeholder replacement.
CSS and JS are linked externally via the existing assets copy step.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore: remove stale team-docs/blog + fix guard for removals (#54)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* chore: trim npm package — exclude docs and contributor files (#48)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* chore: trim npm package — exclude docs, CONTRIBUTING.md, .gitignore

- Removed docs/ from package.json files allowlist (read on GitHub, not runtime)
- Added CONTRIBUTING.md, .gitignore, docs/ to .npmignore (belt-and-suspenders)
- Package: 82 files / 205.7kB -> 30 files / 75.1kB (63% smaller)

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>

* feat: blog migration, team-docs guard, docs site generator (#49, #50, #51) (#52)

* chore: unignore .ai-team/ for dev branches, update contributing guide

- Removed .ai-team/ from .gitignore so team files can be committed on dev/feature branches
- Updated CONTRIBUTING.md to reflect guard workflow as enforcement (not .gitignore)
- Updated guard workflow error message in both live and template copies
- .npmignore still excludes .ai-team/ from the published package

* feat: blog migration, team-docs guard, docs site generator (#49, #50, #51)

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>

* fix: add --base path support to docs build for GitHub Pages

Nav links, search index, and logo all used root-relative paths (/index.html)
which 404 on GitHub Pages where the site is served under /squad/.
Added --base CLI flag to build.js and updated workflows to pass --base /squad.
Also added workflow_dispatch trigger for manual re-deploys.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: extract docs template, CSS, and JS into static files

Moved inline HTML template, CSS, and JS from build.js into separate
files under docs/assets/ (template.html, style.css, script.js).
Build script now reads template and does placeholder replacement.
CSS and JS are linked externally via the existing assets copy step.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore: remove stale team-docs/blog from tracking

Blogs already migrated to docs/blog/ — these stale copies predated
the guard workflow update and leaked to main/preview.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: guard workflow should allow removal of forbidden files

The guard was blocking PRs that *delete* team-docs/ or .ai-team/ files
from protected branches. Deletions are exactly what we want — filter
out files with status 'removed' before checking paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: add 'squad watch' — Ralph local watchdog for persistent polling

Replace aspirational in-session idle-watch (agent can't self-schedule)
with a mechanically sound approach: 'npx squad watch' runs as a
standalone local process that polls GitHub every N minutes for new
squad work.

Three layers of Ralph:
- In-session: 'Ralph, go' active loop while work exists
- Local watchdog: 'npx squad watch --interval N' for persistent polling
- Cloud heartbeat: squad-heartbeat.yml for fully unattended

Changes:
- index.js: Add 'watch' subcommand with --interval flag (default: 10min)
- squad.agent.md: Replace idle-watch self-scheduling with squad watch ref
- docs/features/ralph.md: Document three-layer architecture

* fix: use correct npx package path for squad watch command

The package is published as @bradygaster/create-squad with bin name
'create-squad', so the correct invocation is:

  npx github:bradygaster/squad watch --interval 10

NOT 'npx squad watch' which would fail to resolve.

Updated all references in squad.agent.md and docs/features/ralph.md
to use the correct 'npx github:bradygaster/squad watch' path,
matching the existing convention used throughout the project
(e.g., help text in index.js line 34).

* fix: correct 'npx squad copilot' to full package path

Caught one more instance of the bare 'npx squad' shorthand that
doesn't resolve. The package bin is 'create-squad' under the
@bradygaster scope, so all npx invocations must use the full
'npx github:bradygaster/squad' path.

This was a pre-existing bug in index.js (upgrade hint message)
spotted while fixing the watch command references.

---------

Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
Co-authored-by: bradygaster <bradygaster@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster bradygaster deleted the squad/npmignore-cleanup branch February 27, 2026 01:19
@bradygaster bradygaster mentioned this pull request Mar 10, 2026
Closed
This was referenced Mar 16, 2026
Merged
Open
joniba pushed a commit to joniba/squad that referenced this pull request Mar 26, 2026
fix: purge all lockout rules from source files (Decision bradygaster#48)
7e86502 
Removed Reviewer Rejection Lockout Semantics from:
- .github/agents/squad.agent.md (coordinator governance)
- .squad/templates/squad.agent.md (template copy)
- .squad/templates/charter.md (charter template)
- .squad/templates/run-output.md (review output template)
- .squad/agents/gandalf/charter.md (lead charter)
- templates/squad-starter/charter-templates/lead.md (starter template)

New rule: original authors own their fixes. Reviewers provide
specific feedback; coordinator routes it back to the author.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joniba pushed a commit to joniba/squad that referenced this pull request Mar 26, 2026
@jbenami
[squad] Clean up Frodo's charter — TI Domain Backend Engineer (bradyg…
31f5e5b 
…aster#126)

* fix: purge all lockout rules from source files (Decision bradygaster#48)

Removed Reviewer Rejection Lockout Semantics from:
- .github/agents/squad.agent.md (coordinator governance)
- .squad/templates/squad.agent.md (template copy)
- .squad/templates/charter.md (charter template)
- .squad/templates/run-output.md (review output template)
- .squad/agents/gandalf/charter.md (lead charter)
- templates/squad-starter/charter-templates/lead.md (starter template)

New rule: original authors own their fixes. Reviewers provide
specific feedback; coordinator routes it back to the author.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: clean up Frodo's charter — remove inlined code, reference docs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Elrond <elrond@squad.local>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joniba pushed a commit to joniba/squad that referenced this pull request Mar 26, 2026
@jbenami
[notifications] Phase 1.3: Scheduler integration (bradygaster#117) (b…
50f22c1 
…radygaster#127)

* feat(squad): hire Frodo — TI Domain Backend Engineer

Conservative charter for SecurityInsights RP and Sentinel-TiPipeline work.
Domain knowledge seeded from Sagi's TiExpert PR #15064785 review and
ICM 767184571 investigation (RP-side subscription blocking).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: purge all lockout rules from source files (Decision bradygaster#48)

Removed Reviewer Rejection Lockout Semantics from:
- .github/agents/squad.agent.md (coordinator governance)
- .squad/templates/squad.agent.md (template copy)
- .squad/templates/charter.md (charter template)
- .squad/templates/run-output.md (review output template)
- .squad/agents/gandalf/charter.md (lead charter)
- templates/squad-starter/charter-templates/lead.md (starter template)

New rule: original authors own their fixes. Reviewers provide
specific feedback; coordinator routes it back to the author.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat(notifications): scheduler integration (bradygaster#117)

- Event-driven notification triggers
- Register/unregister/list triggers
- Config-driven trigger mapping (triggers.json)
- Integration hooks for ICM scan, PR review, Ralph rounds
- Full Pester test coverage

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Elrond <elrond@squad.local>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joniba pushed a commit to joniba/squad that referenced this pull request Mar 26, 2026
@jbenami
[dgrep-cli] Phase 1.3: Query execution engine (bradygaster#103) (brad…
7646597 
…ygaster#128)

* feat(squad): hire Frodo — TI Domain Backend Engineer

Conservative charter for SecurityInsights RP and Sentinel-TiPipeline work.
Domain knowledge seeded from Sagi's TiExpert PR #15064785 review and
ICM 767184571 investigation (RP-side subscription blocking).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: purge all lockout rules from source files (Decision bradygaster#48)

Removed Reviewer Rejection Lockout Semantics from:
- .github/agents/squad.agent.md (coordinator governance)
- .squad/templates/squad.agent.md (template copy)
- .squad/templates/charter.md (charter template)
- .squad/templates/run-output.md (review output template)
- .squad/agents/gandalf/charter.md (lead charter)
- templates/squad-starter/charter-templates/lead.md (starter template)

New rule: original authors own their fixes. Reviewers provide
specific feedback; coordinator routes it back to the author.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat(dgrep): query execution engine (bradygaster#103)

- IQueryExecutor interface with MockQueryExecutor and KustoQueryExecutor stub
- TableFormatter, JsonFormatter, CsvFormatter output formatters
- QueryCommand wired to CLI with config defaults (cluster, database, timeout, max-rows)
- Error handling for connection, syntax, timeout, auth failures
- FormatterFactory for output format selection
- Full test coverage (49 new tests, 184 total)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Elrond <elrond@squad.local>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joniba pushed a commit to joniba/squad that referenced this pull request Mar 26, 2026
@jbenami
[dgrep-cli] Phase 2.1: Authentication integration (bradygaster#104) (b…
f28aebd 
…radygaster#129)

* feat(squad): hire Frodo — TI Domain Backend Engineer

Conservative charter for SecurityInsights RP and Sentinel-TiPipeline work.
Domain knowledge seeded from Sagi's TiExpert PR #15064785 review and
ICM 767184571 investigation (RP-side subscription blocking).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: purge all lockout rules from source files (Decision bradygaster#48)

Removed Reviewer Rejection Lockout Semantics from:
- .github/agents/squad.agent.md (coordinator governance)
- .squad/templates/squad.agent.md (template copy)
- .squad/templates/charter.md (charter template)
- .squad/templates/run-output.md (review output template)
- .squad/agents/gandalf/charter.md (lead charter)
- templates/squad-starter/charter-templates/lead.md (starter template)

New rule: original authors own their fixes. Reviewers provide
specific feedback; coordinator routes it back to the author.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: notifications system guide (bradygaster#120)

Adds comprehensive user-facing documentation for the proactive notifications system across three implementation phases: webhook routing, failure recovery, and scheduler integration.

Guide covers:
- Setup and configuration (webhook URL, directory structure)
- Sending notifications for all three tiers (urgent, action, feature)
- Event trigger patterns and integration points
- Failure recovery with dead letter queue and retry scheduler
- Configuration reference (state watermark, dead letter structure)
- Testing and validation commands
- Troubleshooting flowcharts and health checks
- Reference section with Adaptive Card templates

Updates docs/INDEX.md and docs/TAGS.md for proper indexing per Bilbo standards.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat(dgrep): authentication integration (bradygaster#104)

- IAuthProvider interface with AzCli, Certificate, ManagedIdentity providers
- AuthProviderFactory with config-driven selection (default: azcli)
- dgrep auth status/test commands
- KustoQueryExecutor wired with auth provider
- AuthMethod field in DgrepConfig + ConfigManager support
- IProcessRunner abstraction for testable az CLI invocation
- InternalsVisibleTo for test access
- 78 new xUnit tests (262 total, all passing)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Elrond <elrond@squad.local>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joniba pushed a commit to joniba/squad that referenced this pull request Mar 26, 2026
@jbenami
[dgrep-cli] Phase 2.2: Saved queries (bradygaster#105) (bradygaster#130)
f01518a 
* feat(squad): hire Frodo — TI Domain Backend Engineer

Conservative charter for SecurityInsights RP and Sentinel-TiPipeline work.
Domain knowledge seeded from Sagi's TiExpert PR #15064785 review and
ICM 767184571 investigation (RP-side subscription blocking).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: purge all lockout rules from source files (Decision bradygaster#48)

Removed Reviewer Rejection Lockout Semantics from:
- .github/agents/squad.agent.md (coordinator governance)
- .squad/templates/squad.agent.md (template copy)
- .squad/templates/charter.md (charter template)
- .squad/templates/run-output.md (review output template)
- .squad/agents/gandalf/charter.md (lead charter)
- templates/squad-starter/charter-templates/lead.md (starter template)

New rule: original authors own their fixes. Reviewers provide
specific feedback; coordinator routes it back to the author.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: notifications system guide (bradygaster#120)

Adds comprehensive user-facing documentation for the proactive notifications system across three implementation phases: webhook routing, failure recovery, and scheduler integration.

Guide covers:
- Setup and configuration (webhook URL, directory structure)
- Sending notifications for all three tiers (urgent, action, feature)
- Event trigger patterns and integration points
- Failure recovery with dead letter queue and retry scheduler
- Configuration reference (state watermark, dead letter structure)
- Testing and validation commands
- Troubleshooting flowcharts and health checks
- Reference section with Adaptive Card templates

Updates docs/INDEX.md and docs/TAGS.md for proper indexing per Bilbo standards.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat(dgrep): saved queries with parameter substitution (bradygaster#105)

- SavedQuery model with DefaultDatabase, DefaultCluster, {{param}} placeholders
- dgrep saved list/add/remove/show/run commands
- Parameter substitution via {{param_name}} with missing-param validation
- 3 built-in ICM investigation queries (icm-errors, icm-latency, icm-throttling)
- SavedCommand wired into Program.cs via QueryExecutor + ConfigManager
- Full xUnit test coverage (42 new tests, 317 total passing)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Elrond <elrond@squad.local>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joniba pushed a commit to joniba/squad that referenced this pull request Mar 26, 2026
@jbenami
[squad] Frodo charter v2 — proper TI domain charter (bradygaster#131)
35666e3 
* feat(squad): hire Frodo — TI Domain Backend Engineer

Conservative charter for SecurityInsights RP and Sentinel-TiPipeline work.
Domain knowledge seeded from Sagi's TiExpert PR #15064785 review and
ICM 767184571 investigation (RP-side subscription blocking).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: purge all lockout rules from source files (Decision bradygaster#48)

Removed Reviewer Rejection Lockout Semantics from:
- .github/agents/squad.agent.md (coordinator governance)
- .squad/templates/squad.agent.md (template copy)
- .squad/templates/charter.md (charter template)
- .squad/templates/run-output.md (review output template)
- .squad/agents/gandalf/charter.md (lead charter)
- templates/squad-starter/charter-templates/lead.md (starter template)

New rule: original authors own their fixes. Reviewers provide
specific feedback; coordinator routes it back to the author.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: notifications system guide (bradygaster#120)

Adds comprehensive user-facing documentation for the proactive notifications system across three implementation phases: webhook routing, failure recovery, and scheduler integration.

Guide covers:
- Setup and configuration (webhook URL, directory structure)
- Sending notifications for all three tiers (urgent, action, feature)
- Event trigger patterns and integration points
- Failure recovery with dead letter queue and retry scheduler
- Configuration reference (state watermark, dead letter structure)
- Testing and validation commands
- Troubleshooting flowcharts and health checks
- Reference section with Adaptive Card templates

Updates docs/INDEX.md and docs/TAGS.md for proper indexing per Bilbo standards.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: notifications status assessment — honest gap analysis

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(dgrep): Windows process runner for az.cmd invocation (bradygaster#110)

On Windows, az is az.cmd (batch file). Process.Start with
UseShellExecute=false can't find it. Fix: resolve .cmd extension
on Windows before spawning process.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: Frodo charter v2 — domain-grounded, no link indirection

Complete rewrite of Frodo's charter based on deep TI domain research.

Changes:
- Removed ICM-specific content (767184571, 764634026)
- Removed link indirection to PR reviews and external docs
- Added inline TI domain knowledge: 4-layer pipeline architecture
  (Ingestion, Processing, Storage, Matching), all repos covered
- Extracted concrete patterns from Galadriel's reviews (STIX inheritance,
  error handling contracts, API versioning, polling discipline)
- Expanded scope from 2 repos to entire TI domain (C:\dev\ti)
- Kept conservative philosophy, EMU auth, failure recovery unchanged

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: incorporate Elrond's TI domain research into Frodo charter

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Elrond <elrond@squad.local>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@diberry diberry mentioned this pull request Apr 5, 2026
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bradygaster