feat(sdk): StorageProvider interface + FSStorageProvider (#481)#567
Closed
diberry wants to merge 1 commit intobradygaster:devfrom
Closed
feat(sdk): StorageProvider interface + FSStorageProvider (#481)#567diberry wants to merge 1 commit intobradygaster:devfrom
diberry wants to merge 1 commit intobradygaster:devfrom
Conversation
Owner
|
please fix formatting issues |
Owner
🔍 Squad Team ReviewReviewed by: CONTROL (TypeScript Engineer) — Pass 3 of consensus ceremony Review SummaryStorageProvider interface + FSStorageProvider. Currently in draft. Properly scoped and has tests. Awaiting author to mark ready for review. ✅ Verdict: HOLD — awaiting author to mark ready |
Collaborator
Author
|
Closing as duplicate — superseded by #640 (StorageProvider full migration). |
Collaborator
Author
|
Reopening — this is the smaller foundational PR. The full migration (#640) is being closed instead. |
…#481) Wave 1 foundation: defines the 9-method StorageProvider interface (6 async + 3 sync) and implements FSStorageProvider as a drop-in wrapper around Node.js fs. No call sites migrated yet — this PR establishes the abstraction layer only. Decisions: DI with config fallback, both sync/async, sync deprecated after Wave 2 migration. Closes bradygaster#481 (Wave 1) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry
force-pushed
the
squad/481-storage-provider
branch
from
391777c to
fd6b571
Compare
Collaborator
Author
|
Closing -- this was the interface-only skeleton (6 files, 321 additions). The complete StorageProvider migration with all 3 providers, error handling, and consumer wiring is in #640. Archiving this as incomplete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 1: Storage Abstraction Layer
Defines the \StorageProvider\ interface and ships \FSStorageProvider\ as a drop-in default. No call sites are migrated — this is the foundation only.
What's in this PR
Design decisions (per Dina)
Test results
\
✓ FSStorageProvider (18 tests) 135ms — all passed
\\
Build
Clean build with \SKIP_BUILD_BUMP=1.
Working as EECOM (Core Dev)
Closes #481 (Wave 1)