feat(skills): add directive-capture skill -- auto-detect and persist user directives#614
feat(skills): add directive-capture skill -- auto-detect and persist user directives#614tamirdresher wants to merge 2 commits intobradygaster:devfrom
Conversation
Adds a new skill that teaches the coordinator to recognize standing directives embedded in user messages (e.g. 'always use TypeScript strict mode', 'we don't use Redux anymore') and capture them to the decisions inbox for Scribe to merge into decisions.md. Includes: - Signal word detection patterns (always, never, from now on, etc.) - Clear distinction between directives vs work requests - Capture file format and inbox workflow - Coordinator prompt enhancement paragraph - Five worked examples including mixed messages - Anti-patterns to avoid false captures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔍 Squad Team ReviewReviewed by: CONTROL (TypeScript Engineer) — Pass 3 of consensus ceremony Review SummaryThis PR adds a directive-capture skill. However, directive capture is already built into the coordinator prompt in RecommendationWe recommend closing this PR. The functionality already exists in the coordinator prompt. If you'd like to enhance directive capture, consider contributing to the existing implementation in Thank you for the contribution! 🙏 ❌ Verdict: CLOSE — duplicates existing functionality |
bradygaster
left a comment
bradygaster
left a comment
There was a problem hiding this comment.
FIDO Quality Review — PR #614: directive-capture skill
Verdict:
Blocking Issue
❌ Wrong package names in changeset: The .changeset/directive-capture-skill.md uses squad-cli and squad-sdk instead of @bradygaster/squad-cli and @bradygaster/squad-sdk. Same issue as PRs #623, #622, #621.
Fix: Change the changeset frontmatter to:
\\yaml
"@bradygaster/squad-cli": minor
"@bradygaster/squad-sdk": minor
\\
Non-Blocking Notes
- Target branch: Targets
main— considerdev. - SKILL.md format: Frontmatter is correct with all required fields (name, description, domain, confidence, source). ✅ This one follows the template better than the other PRs.
- Content quality: Excellent. Clear directive detection patterns, well-defined what-is vs what-is-not, concrete examples covering pure directives, negative directives, process directives, non-directives, and mixed messages. The coordinator prompt enhancement section is practical.
- File paths: Correct placement in both CLI and SDK template directories.
Fix the changeset package names and this merges cleanly.
|
Fixed per FIDO review: corrected changeset package names from squad-cli/squad-sdk to @bradygaster/squad-cli/@bradygaster/squad-sdk. Also retargeting to dev branch. |
|
Thank you for this contribution, Tamir! 🙏 We've discovered that directive capture functionality is already implemented in the coordinator prompt's Directive Capture section in squad.agent.md. The coordinator has built-in logic to recognize and capture directives from user interactions. If you'd like to improve or refine the existing directive capture implementation, we'd love to see your ideas! Please propose those changes directly to the coordinator prompt instead. Thanks for thinking about this—we value your contributions! |
2 participants
Summary
Adds directive-capture skill for auto-detecting and persisting user directives.
Battle-tested in 13-agent production deployment. Zero breaking changes.
Closes #677