fix(consult): use personal-squad dir in getPersonalSquadRoot() (#590)#615
Closed
tamirdresher wants to merge 1 commit intobradygaster:mainfrom
Closed
fix(consult): use personal-squad dir in getPersonalSquadRoot() (#590)#615tamirdresher wants to merge 1 commit intobradygaster:mainfrom
tamirdresher wants to merge 1 commit intobradygaster:mainfrom
Conversation
getPersonalSquadRoot() was appending '.squad' to the global squad directory, resolving to an empty folder instead of the actual personal squad at personal-squad/. This caused squad consult to enter Init Mode even when a personal squad exists. Fixes bradygaster#590
Collaborator
Author
|
Closing — bradygaster has opened #620 which fixes the same issue with a more comprehensive implementation (also fixes shell/index.ts:151 + adds 3 tests via internal review). Deferring to that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a path resolution bug where getPersonalSquadRoot() in consult.ts returns the wrong directory, causing squad consult to enter Init Mode even when a personal squad exists.
Root Cause
getPersonalSquadRoot() appends '.squad' to the global squad config path, resolving to an empty path instead of the personal-squad directory.
This is consistent with resolvePersonalSquadDir() in resolution.ts which correctly uses 'personal-squad'.
Fixes #590