feat(ci): add test count guard to prevent AI agents from deleting tests#642
Closed
diberry wants to merge 1 commit intobradygaster:devfrom
Closed
feat(ci): add test count guard to prevent AI agents from deleting tests#642diberry wants to merge 1 commit intobradygaster:devfrom
diberry wants to merge 1 commit intobradygaster:devfrom
Conversation
Adds a CI step that compares the current test count against a baseline stored in .github/test-baseline.json. PRs that reduce the test count below baseline are rejected. Also updates copilot-instructions.md with explicit 'never delete tests' directive for @copilot and other AI agents. Closes #39 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
@bradygaster Ready for your review — team-approved with 3-reviewer gate (Flight, FIDO, Procedures). |
larsontim12
pushed a commit
to larsontim12/squad
that referenced
this pull request
Mar 27, 2026
bradygaster#642) * fix: dedup concurrent connect() calls in SquadClient When the REPL starts with .init-prompt and an empty roster, eager session warm-up and auto-cast race to call connect(). The second call hit state=connecting and threw 'Connection already in progress'. Replace the throwing guard with a connection promise dedup pattern: concurrent callers now share the same in-flight promise instead of crashing. connectPromise is cleared on completion and in disconnect/ forceDisconnect for clean state reset. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: add concurrent connect() dedup tests Update adapter-client tests for the new connect() dedup behavior. Replace the old 'throws on concurrent connect' test with tests that verify concurrent callers share the same promise: both resolve on success, both reject on failure, and fresh connect works after failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: merge connect dedup decision into decisions.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Closing as duplicate — Brady merged the same goal (test deletion guard) in #634 (source tree canary). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI guard script that compares actual test count against a baseline, blocking PRs that reduce test count. Prevents AI agents from deleting tests to make failing code pass.
Team review: Flight ✅, FIDO ✅, Procedures ✅
Closes diberry#39