fix(docs): P0 quality fixes with regression tests#651
Closed
diberry wants to merge 1 commit intobradygaster:devfrom
Closed
fix(docs): P0 quality fixes with regression tests#651diberry wants to merge 1 commit intobradygaster:devfrom
diberry wants to merge 1 commit intobradygaster:devfrom
Conversation
…atch + regression tests - Remove duplicate H2 headings in team-setup, routing, parallel-execution, directives - Fix Streams title mismatch (SubSquads → Streams) - Delete 6 orphan pages not in navigation (guide.md, sample-prompts.md, tips-and-tricks.md, tour-*.md) - Fix internal link in personal-squad.md - Add 3 regression tests: duplicate H2 detection, orphan page detection, nav/title mismatch detection Closes #62 (partial — P0 items) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
larsontim12
pushed a commit
to larsontim12/squad
that referenced
this pull request
Mar 27, 2026
…gaster#666, bradygaster#676) (bradygaster#682) * docs(ai-team): CLI UI Polish PRD finalized — 20 issues created Session: 2026-03-01T20-13-00Z-ui-polish-prd Requested by: Brady Changes: - Created 6 orchestration logs (.squad/orchestration-log/2026-03-01T20-24-57Z-*.md) - Created session log (.squad/log/2026-03-01T20-13-00Z-ui-polish-prd.md) - Merged 5 decision files into decisions.md (PRD strategy, cast confirmation, processing state, Brady directives) - Deleted inbox files after merge (deduplication complete) - Updated team history files (Cheritto, Kovash, Redfoot, Marquez, Keaton, Fenster) - PRD created (docs/prd-cli-ui-polish.md) with 20 discrete issues (bradygaster#662-681) for alpha-1 release - Pragmatic alpha-first strategy: P0 blockers (blank screens, spinner, banner) + P1 quick wins, defer grand redesign Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(tui): consolidate separators, fix empty space, add info hierarchy and breathing room (bradygaster#655, bradygaster#670, bradygaster#671, bradygaster#677) - Create shared Separator component in components/Separator.tsx (bradygaster#677) All inline separator rendering (box.h.repeat) replaced across App.tsx, AgentPanel.tsx, and MessageStream.tsx - Remove flexGrow={1} from MessageStream outer Box (bradygaster#655) This was pushing content to bottom of viewport with empty space above - Bold primary CTAs in dim contexts (bradygaster#670) Header: @agent and /help now bold within dimColor usage line First-run: 'Try:' prompt bolded AgentPanel empty state: 'Send a message' and '/help' bolded - Add whitespace breathing room (bradygaster#671) Header wrapper gets marginBottom={1} Turn separators get marginTop={1} AgentPanel bottom separators upgraded from marginTop={0} to marginTop={1} Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: update Cheritto history and add separator decision Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: wire onPermissionRequest handler in CLI session creation (bradygaster#651) Add approveAllPermissions handler to all 4 client.createSession() calls in the CLI shell. The handler was defined in SDK adapter types but never wired, causing a raw SDK error for users. - Add approve-all handler in shell/index.ts (CLI runs locally with user trust) - Export SquadPermissionHandler types from @bradygaster/squad-sdk/client - Add clear error guidance in adapter/client.ts for missing handler Closes bradygaster#651 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(tui): bump secondary text contrast and wire table wrapping (bradygaster#666, bradygaster#676) - Replace dimColor with color="gray" for secondary text (system messages, italic markdown, duration labels, agent activity feed) — higher contrast than dim on dark terminals - Add GRAY ANSI constant and secondary() helper to output.ts - Add wrapTableContent() + truncateTableColumns() to MessageStream — tables exceeding terminal width are column-truncated with ellipsis - Wire table wrapping into both message history and streaming content paths Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Closing -- will re-open via fork-first pipeline when fully polished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TDD approach: regression tests written first (red), then fixes applied (green).
P0 fixes from diberry#62 analysis:
Regression tests added:
All 3 new tests pass. 25 total tests (22 existing + 3 new).
@bradygaster — docs quality fixes from IA analysis. TDD-verified with regression guards.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com