feat(ci): add samples build validation gate by diberry · Pull Request #674 · bradygaster/squad

diberry · 2026-03-29T01:57:36Z

Part 3: Repo Health -- Samples Build CI Gate

What

Adds a samples-build job to squad-ci.yml that validates all sample projects still compile and pass tests when SDK source files change.

Why

The 11 sample projects in samples/ ship with zero CI coverage. SDK changes can silently break samples, which users discover only when they try to follow a tutorial. This gate catches breakage at PR time, not after release.

Issue: #103
Gate 3 tracking: #104

How

New samples-build job in .github/workflows/squad-ci.yml
Only triggers on pull requests (same as changelog-gate and exports-map-check)
Only runs when files in packages/squad-sdk/src/ are changed (three-dot diff)
Feature-flagged: gate is ENABLED by default; set vars.SQUAD_SAMPLES_CI to false to disable
Skip label: skip-samples-ci (uses github.event.pull_request.labels per Copilot review lesson)
Installs root dependencies and builds the SDK first (samples reference SDK via file: links)
Loops through each samples/*/ directory:
- Skips samples without package.json
- Skips samples with no build or test scripts
- Runs npm install, then npm run build and/or npm run test as applicable
Reports a summary with pass/fail/skip counts per sample
Uses GitHub Actions annotations (::error::, ::notice::) for clear CI output

Samples Inventory

Sample	Build	Test	SDK Dep
autonomous-pipeline	tsc	vitest	npm
azure-function-squad	tsc	tsx dry-run	file:
cost-aware-router	tsc	vitest	npm
hello-squad	--	vitest	file:
hook-governance	--	vitest	file:
knock-knock	--	--	file:
rock-paper-scissors	--	--	file:
skill-discovery	--	vitest	file:
storage-provider-azure	N/A	N/A	N/A
storage-provider-sqlite	N/A	N/A	N/A
streaming-chat	tsc --noEmit	vitest	file:

Related Issues

Closes Workflow dual-path support for .squad/ migration #103
Part of Gate 3: Merge .ai-team-templates/ into .squad/templates/ #104

Testing

npm run build -- passes
npm test -- 173 suites pass; 11 failures are pre-existing vitest worker timeouts unrelated to this YAML-only change
YAML change reviewed for correct indentation and step conditional logic
Feature flag and skip label patterns match existing changelog-gate and exports-map-check gates

Breaking Changes

None. This is an additive CI gate. It does not block existing jobs and can be disabled via feature flag or skip label.

Waivers

None requested.

Preflight

npm run build -- passes
npm test -- 173 suites pass, 11 pre-existing timeout failures (vitest worker resource exhaustion on Windows)

diberry · 2026-03-29T01:57:48Z

@bradygaster Part 3 of the repo health series (after #672 PR requirements and #673 CI completeness gates). This adds CI coverage for all 11 sample projects -- SDK changes that break samples are now caught at PR time. CI green and ready to merge.

Copilot

Pull request overview

Adds CI validation gates to ensure SDK changes don’t silently break repo expectations—most notably by compiling/testing sample projects on PRs.

Changes:

Adds a samples-build job that builds the SDK and then builds/tests each samples/* project when packages/squad-sdk/src/** changes.
Adds feature-flag + skip-label behavior to conditionally bypass the samples gate.
Introduces changelog-gate and exports-map-check jobs alongside the samples gate.

diberry · 2026-03-29T02:12:49Z

Fixed -- removed changelog-gate and exports-map-check from the diff. This PR now only adds the samples-build job. Those other gates are in PR #673.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

diberry · 2026-03-29T02:19:09Z

Valid enhancement -- tracked in diberry#112 (Samples CI enhancements). This PR ships the initial gate that catches build/test failures in samples with file: SDK references (8 of 11 samples). The npm-registry samples (autonomous-pipeline, cost-aware-router) need SDK reference patching to test against PR changes -- that is a follow-up.

diberry · 2026-03-29T02:21:14Z

Fixed -- added a CI step that patches npm-registry samples (autonomous-pipeline, cost-aware-router) to use file:../../packages/squad-sdk before running builds. All 11 samples now validate against the PR's SDK changes.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

tamirdresher · 2026-03-29T06:15:22Z

@diberry is this ready to merge? i see a conflict

…eed heuristic - Fix sample count: 11 → 9 (actual count in samples/ directory) - Mark samples-build and changelog/exports gates as pending merge (#673, #674) - Add concrete heuristic for bleed check (scope by packages/ directory) - Clarify bash snippet as reference commands, not literal agent execution Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Closes #103 Adds samples-build CI job that validates all 11 samples compile when SDK changes. - Loops samples/ directories with npm install/build/test - Feature-flagged via skip-samples-build label - 15-minute timeout, --ignore-scripts, npm cache - Accepted Copilot suggestions: cache-dependency-path, workspace root install Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Remove changelog-gate and exports-map-check from this PR's diff. Those gates are in PR bradygaster#673. This PR should only add samples-build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot review found that samples using @bradygaster/squad-sdk from npm registry (autonomous-pipeline, cost-aware-router) were not validated against the PR's SDK changes. This step rewrites their package.json to use file:../../packages/squad-sdk before running builds and tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diberry · 2026-03-29T13:53:22Z

Merge conflict resolved — rebased onto upstream/dev

What happened: PR #673 (changelog-gate + exports-map-check) merged to upstream/dev while this PR was open. Both PRs added content to the same region of squad-ci.yml (between the test and publish-policy jobs), causing a merge conflict.

How it was resolved:

Rebased the PR branch onto latest upstream/dev
Kept upstream's changelog-gate and exports-map-check jobs exactly as-is (from PR feat(ci): add CHANGELOG and exports map completeness gates #673)
Added only the samples-build job from this PR
Resolved 5 conflict regions across 7 rebased commits (2 dropped as already upstream)
Fixed a duplicate cache-dependency-path that snuck in during the conflict

Final diff: 1 file changed, 151 additions — scoped exclusively to the samples-build job. No changes to changelog-gate or exports-map-check.

The CI workflow now has all 6 jobs in order: docs-quality, test, changelog-gate, exports-map-check, samples-build, publish-policy.

@tamirdresher — conflict is resolved, should be mergeable now.

tamirdresher

Reviewed: 1 file changed (squad-ci.yml only), all 6 CI checks green, all 8 Copilot review findings resolved. Clean samples-build gate with feature flag + skip label pattern matching existing gates. LGTM.

) Adds useTerminalHeight() hook and viewport-aware layout with height-bounded content area. Reserves 3 rows for InputPrompt. Closes bradygaster#674 Closes bradygaster#675

diberry marked this pull request as ready for review March 29, 2026 01:57

Copilot AI review requested due to automatic review settings March 29, 2026 01:57

diberry mentioned this pull request Mar 29, 2026

Squad product: samples/ directory has zero CI coverage -- SDK changes silently break samples diberry/squad#103

Closed

43 tasks

Copilot started reviewing on behalf of diberry March 29, 2026 01:58 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Comment thread .github/workflows/squad-ci.yml Outdated

Comment thread .github/workflows/squad-ci.yml

Comment thread .github/workflows/squad-ci.yml Outdated

Comment thread .github/workflows/squad-ci.yml Outdated

diberry requested a review from Copilot March 29, 2026 02:13

Copilot started reviewing on behalf of diberry March 29, 2026 02:14 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Comment thread .github/workflows/squad-ci.yml Outdated

Comment thread .github/workflows/squad-ci.yml

diberry requested a review from Copilot March 29, 2026 02:22

Copilot started reviewing on behalf of diberry March 29, 2026 02:22 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Comment thread .github/workflows/squad-ci.yml

diberry requested a review from Copilot March 29, 2026 02:45

Copilot started reviewing on behalf of diberry March 29, 2026 02:45 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Comment thread .github/workflows/squad-ci.yml Outdated

Copilot AI mentioned this pull request Mar 29, 2026

feat: enhance FIDO with PR requirements enforcement + workflow guide #676

Closed

5 tasks

diberry and others added 5 commits March 29, 2026 06:47

Update .github/workflows/squad-ci.yml

e4226de

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: scope PR to samples-build gate only

4730c5a

Remove changelog-gate and exports-map-check from this PR's diff. Those gates are in PR bradygaster#673. This PR should only add samples-build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update .github/workflows/squad-ci.yml

46f626c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

diberry force-pushed the squad/103-samples-ci-upstream branch from 8b84703 to d6c8d7c Compare March 29, 2026 13:50

diberry mentioned this pull request Mar 29, 2026

feat(sdk): StorageProvider abstraction — complete migration + example providers #640

Merged

tamirdresher approved these changes Mar 29, 2026

View reviewed changes

tamirdresher merged commit 1513359 into bradygaster:dev Mar 29, 2026
6 checks passed

Conversation

diberry commented Mar 29, 2026

Part 3: Repo Health -- Samples Build CI Gate

What

Why

How

Samples Inventory

Related Issues

Testing

Breaking Changes

Waivers

Preflight

Uh oh!

diberry commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

diberry commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

diberry commented Mar 29, 2026

Uh oh!

diberry commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

tamirdresher commented Mar 29, 2026

Uh oh!

diberry commented Mar 29, 2026

Merge conflict resolved — rebased onto upstream/dev

Uh oh!

tamirdresher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants