feat(ci): add file list with line stats to PR readiness comment#813
Merged
feat(ci): add file list with line stats to PR readiness comment#813
Conversation
Contributor
🛫 PR Readiness Check
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | 0 active Copilot thread(s) resolved (2 outdated skipped) |
| ❌ | CI passing | 16 check(s) still running |
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the PR readiness comment posted by scripts/pr-readiness.mjs by adding a “Files Changed” markdown section that lists each changed file along with additions/deletions totals, helping reviewers gauge PR scope at a glance.
Changes:
- Add
buildFileList(files)to render a per-file line-stat table plus totals. - Extend
buildChecklist(...)to optionally append the file list section whenfilesare available. - Add unit/integration tests covering file list rendering and inclusion in the upserted PR readiness comment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/pr-readiness.mjs |
Adds buildFileList() and wires it into the readiness comment output via buildChecklist() / run(). |
test/pr-readiness.test.ts |
Adds tests for buildFileList() formatting and verifies the file list appears in the posted readiness comment. |
diberry
force-pushed
the
squad/readiness-file-list
branch
from
b9cbfd4 to
6e1ca2c
Compare
Contributor
🏗️ Architectural Review
Automated architectural review — informational only. |
diberry
force-pushed
the
squad/readiness-file-list
branch
2 times, most recently
from
12c19f3 to
2210f34
Compare
diberry
force-pushed
the
squad/readiness-file-list
branch
from
2210f34 to
6d7f3c5
Compare
Contributor
🟡 Impact Analysis — PR #813Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
root (2 files)
scripts (1 file)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
diberry
force-pushed
the
squad/readiness-file-list
branch
2 times, most recently
from
782d333 to
155ab4f
Compare
tamirdresher
approved these changes
Apr 5, 2026
Collaborator
tamirdresher
left a comment
tamirdresher
left a comment
There was a problem hiding this comment.
✅ LGTM — Thorough file list + scope classification with 16 tests. Good markdown safety with sanitizeFilename().
…tles to PR readiness - Add file list table with per-file +additions/-deletions stats - Add PR scope classification (Product/Infrastructure/Mixed) - Rename Architectural Review and Security Review checks with descriptive subtitles Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry
force-pushed
the
squad/readiness-file-list
branch
from
155ab4f to
ccdde89
Compare
tamirdresher
added a commit
that referenced
this pull request
Apr 8, 2026
) * feat(ci): add file list with line stats, scope badge, and check subtitles to PR readiness (#813) - Add file list table with per-file +additions/-deletions stats - Add PR scope classification (Product/Infrastructure/Mixed) - Rename Architectural Review and Security Review checks with descriptive subtitles Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * ci: scope boundary enforcement for repo-health PRs (#826) Add CI check that fails when repo-health PRs include product source code changes under packages/*/src/. Prevents scope creep where infrastructure PRs accidentally touch product code. - Add squad-scope-check.yml workflow - Document PR scope rules in copilot-instructions.md - Fail loudly on git diff errors instead of silently passing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * ci: smart PR nudge for stale PRs (#827) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: add cross-package export smoke test to catch missing imports Validates every value import squad-cli uses from squad-sdk resolves to a defined export at runtime. Covers 15 SDK subpaths and 50+ named exports including FSStorageProvider, SquadClient, CastingEngine, RalphMonitor, and all resolution/config/platform helpers. Also verifies that every entry in the SDK package.json exports map points to a file that actually exists on disk. Motivation: v0.9.3-insider.1 shipped with FSStorageProvider missing from the SDK barrel — broke users at runtime while all TS-level tests passed (TypeScript resolves from source, not compiled output). Refs: #836 --------- Co-authored-by: Dina Berry (MSFT) <diberry@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
tamirdresher
added a commit
that referenced
this pull request
Apr 21, 2026
) * feat(ci): add file list with line stats, scope badge, and check subtitles to PR readiness (#813) - Add file list table with per-file +additions/-deletions stats - Add PR scope classification (Product/Infrastructure/Mixed) - Rename Architectural Review and Security Review checks with descriptive subtitles Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * ci: scope boundary enforcement for repo-health PRs (#826) Add CI check that fails when repo-health PRs include product source code changes under packages/*/src/. Prevents scope creep where infrastructure PRs accidentally touch product code. - Add squad-scope-check.yml workflow - Document PR scope rules in copilot-instructions.md - Fail loudly on git diff errors instead of silently passing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * ci: smart PR nudge for stale PRs (#827) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: add cross-package export smoke test to catch missing imports Validates every value import squad-cli uses from squad-sdk resolves to a defined export at runtime. Covers 15 SDK subpaths and 50+ named exports including FSStorageProvider, SquadClient, CastingEngine, RalphMonitor, and all resolution/config/platform helpers. Also verifies that every entry in the SDK package.json exports map points to a file that actually exists on disk. Motivation: v0.9.3-insider.1 shipped with FSStorageProvider missing from the SDK barrel — broke users at runtime while all TS-level tests passed (TypeScript resolves from source, not compiled output). Refs: #836 --------- Co-authored-by: Dina Berry (MSFT) <diberry@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a file change summary table to the PR readiness comment showing each file with +/- line counts. Helps reviewers quickly assess PR scope.
Files:
scripts/pr-readiness.mjs— addbuildFileList()function and integrate intobuildChecklist()test/pr-readiness.test.ts— add 16 tests for file list formatting and integration