ci: PR contamination prevention guard#825
Conversation
🛫 PR Readiness Check
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 2 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | 0 active Copilot thread(s) resolved (3 outdated skipped) |
| ❌ | CI passing | 14 check(s) still running |
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
🟡 Impact Analysis — PR #825Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (3 files)
root (2 files)
This report is generated automatically for every PR. See #733 for details. |
fef41a1 to
e8c3f65
Compare
🏗️ Architectural Review
Automated architectural review — informational only. |
There was a problem hiding this comment.
Pull request overview
Improves contributor guidance to reduce missing changesets by adding prominent reminders in the PR template and expanding Copilot repository instructions around changesets and PR hygiene.
Changes:
- Added a “Quick Check” changeset reminder and an additional diff-verification item to the PR template checklist.
- Added branch hygiene guidance (“Branch Contamination Prevention”) to Copilot instructions.
- Added PR scope rules and a detailed “Changeset Requirement” section (including examples and an escape hatch) to Copilot instructions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/PULL_REQUEST_TEMPLATE.md |
Adds a prominent changeset reminder and an extra checklist item to verify staged diff contents. |
.github/copilot-instructions.md |
Adds new sections for branch hygiene, PR scoping rules, and changeset requirements with examples. |
c5f3597 to
9d0da67
Compare
- Add Diff Size Guard job to squad-repo-health.yml that warns when single-commit PRs touch 30+ files (likely contamination) - Add branch contamination prevention rules to copilot-instructions.md - Add diff verification checklist item to PR template Prevents the recurring issue where git add -A on stale branches contaminates PRs with unrelated changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9d0da67 to
e166f13
Compare
tamirdresher
left a comment
There was a problem hiding this comment.
✅ LGTM — Warning-only diff guard is the right approach. Heuristic (≤2 commits + >30 files) catches the real contamination pattern without blocking legitimate large PRs. Branch hygiene rules in copilot-instructions and PR template checkbox are good additions.
tamirdresher
left a comment
There was a problem hiding this comment.
✅ LGTM — Warning-only diff guard catches contamination. Branch hygiene rules and PR template checkbox are good additions.
Adds:
Prevents the recurring issue where
git add -Aon stale branches contaminates PRs with unrelated changes.Repo-health PR — no product code changes.