test: add integration tests for watch capabilities (#709)#868
Merged
Conversation
Contributor
🟢 Impact Analysis — PR #868Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedtests (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 2 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ❌ | Branch up to date | dev is 3 commit(s) ahead — rebase recommended |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | 0 active Copilot thread(s) resolved (1 outdated skipped) |
| ❌ | CI passing | 16 check(s) still running |
Files Changed (1 file, +713 −0)
| File | +/− |
|---|---|
test/cli/watch-capabilities.test.ts |
+713 −0 |
Total: +713 −0
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new vitest suite to cover the highest-risk squad watch capability plugins introduced in/around #709, improving confidence in preflight gating, filtering logic, and subprocess-driven flows without relying on real gh, git, or filesystem state.
Changes:
- Adds a comprehensive
watch-capabilitiestest suite covering Execute, Cleanup, Decision Hygiene, Self Pull, and Board capability behaviors. - Introduces shared mocks for SDK storage,
child_process, andfsto keep tests deterministic.
diberry
force-pushed
the
squad/709-watch-capability-tests
branch
from
9e3185a to
9069171
Compare
Add 51 tests covering 5 watch capabilities (execute, cleanup, decision-hygiene, self-pull, board) that shipped with zero test coverage in PR #709. Test coverage: - ExecuteCapability: buildAgentPrompt, findExecutableIssues edge cases, preflight, execute flow (adapter mock, agent dispatch, errors, timeouts) - CleanupCapability: preflight, round-skipping, file pruning by date, stale inbox warnings, config validation - DecisionHygieneCapability: preflight, threshold logic, merge trigger, timeout handling - SelfPullCapability: preflight, git stash/fetch/pull flow, stash pop failure, source change detection - BoardCapability: preflight checks Closes #709 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry
force-pushed
the
squad/709-watch-capability-tests
branch
from
9069171 to
4f7a946
Compare
tamirdresher
approved these changes
Apr 7, 2026
Collaborator
tamirdresher
left a comment
tamirdresher
left a comment
There was a problem hiding this comment.
Approved by @tamirdresher — reviewed diff, CI green, changes are clean and well-tested. cc @diberry
tamirdresher
pushed a commit
that referenced
this pull request
Apr 21, 2026
Add 51 tests covering 5 watch capabilities (execute, cleanup, decision-hygiene, self-pull, board) that shipped with zero test coverage in PR #709. Test coverage: - ExecuteCapability: buildAgentPrompt, findExecutableIssues edge cases, preflight, execute flow (adapter mock, agent dispatch, errors, timeouts) - CleanupCapability: preflight, round-skipping, file pruning by date, stale inbox warnings, config validation - DecisionHygieneCapability: preflight, threshold logic, merge trigger, timeout handling - SelfPullCapability: preflight, git stash/fetch/pull flow, stash pop failure, source change detection - BoardCapability: preflight checks Closes #709 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Closed by #theSquadsquad triage — stale/answered, no further action needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 51 tests covering the 5 highest-risk watch capabilities that shipped in PR #709 with zero test coverage. This was flagged as 🟡 High priority in the architecture review.
Capabilities tested
Closes #709