docs: add contributor-to-core-team PR handoff process#902
Merged
tamirdresher merged 4 commits intodevfrom Apr 8, 2026
Merged
Conversation
External contributors can't use "Fix with Copilot" on review comments (requires write access). Document the explicit handoff flow: - Contributor: CI green + undraft + accept Copilot suggestions - Core team: address remaining Copilot issues, review, merge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🟢 Impact Analysis — PR #902Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the contributor documentation to formalize a “Contributor → Core Team” handoff point for PRs, clarifying how external contributors can signal readiness when they don’t have repo write access (e.g., can’t use “Fix with Copilot”).
Changes:
- Updates the “Pull Request Process” to start with a draft PR and explicitly call out “Ready for review” as the handoff signal.
- Adds a new “Handoff: Contributor → Core Team” section detailing contributor/core-team responsibilities and the “Fix with Copilot” permission limitation.
…nges Agent-Logs-Url: https://github.com/bradygaster/squad/sessions/d6374ed4-60de-4839-b33f-0ba5b311ec81 Co-authored-by: diberry <41597107+diberry@users.noreply.github.com>
External fork contributors cannot use "Commit suggestion" or "Fix with Copilot" buttons — both require write access. Updated to say "manually apply in your fork and push" which is the actual workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher
approved these changes
Apr 8, 2026
Collaborator
tamirdresher
left a comment
tamirdresher
left a comment
There was a problem hiding this comment.
LGTM — clear, practical handoff docs for external contributors. Good callout about Copilot suggestion buttons not working from forks.
tamirdresher
approved these changes
Apr 8, 2026
Collaborator
tamirdresher
left a comment
tamirdresher
left a comment
There was a problem hiding this comment.
LGTM. Clear, practical handoff docs for external contributors. Good callout about Copilot suggestion buttons not working from forks.
tamirdresher
pushed a commit
that referenced
this pull request
Apr 21, 2026
* docs: add contributor-to-core-team handoff process in CONTRIBUTING.md External contributors can't use "Fix with Copilot" on review comments (requires write access). Document the explicit handoff flow: - Contributor: CI green + undraft + accept Copilot suggestions - Core team: address remaining Copilot issues, review, merge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: clarify changeset CI check is conditional on SDK/CLI source changes Agent-Logs-Url: https://github.com/bradygaster/squad/sessions/d6374ed4-60de-4839-b33f-0ba5b311ec81 Co-authored-by: diberry <41597107+diberry@users.noreply.github.com> * docs: fix misleading Copilot suggestion permissions claim External fork contributors cannot use "Commit suggestion" or "Fix with Copilot" buttons — both require write access. Updated to say "manually apply in your fork and push" which is the actual workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Owner
|
Closed by #theSquadsquad triage — verified fixed in v0.9.4 (PR #919 merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.