Skip to content

ci: skip prerelease version guard on insider branch [ON HOLD]#903

Merged
diberry merged 1 commit intodevfrom
diberry/fix-version-guard-insider
Apr 8, 2026
Merged

ci: skip prerelease version guard on insider branch [ON HOLD]#903
diberry merged 1 commit intodevfrom
diberry/fix-version-guard-insider

Conversation

@diberry
Copy link
Copy Markdown
Collaborator

@diberry diberry commented Apr 7, 2026

What

Skip the prerelease version guard when the PR targets the insider branch.

Why

The prerelease-version-guard step in Squad CI blocks packages with prerelease suffixes (e.g., 0.9.4-insider.1) from merging. This is correct for PRs targeting dev or main, but false-positive on insider where prerelease versions are expected and intentional.

This causes every PR targeting insider to show a CI failure, including PR #900.

How

Added one condition to the guard's if: block:

yaml && github.event.pull_request.base.ref != 'insider'

1 file, 1 line added. The guard still runs on PRs to dev, main, and preview.

Testing

  • CI workflow change only — no product code
  • Verified the existing if: block syntax is valid YAML multi-line
  • The skip-version-check label still works as an escape hatch

/cc @bradygaster @tamirdresher

Copilot AI review requested due to automatic review settings April 7, 2026 16:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

🏗️ Architectural Review

⚠️ Architectural review: 1 info.

Severity Category Finding Files
ℹ️ info template-sync Template files changed in .github/workflows/ but not in other template locations. If these templates should stay in sync, consider updating the others too. Changed: .github/workflows/, Unchanged: templates/, .squad-templates/, packages/squad-cli/templates/

Automated architectural review — informational only.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

🟢 Impact Analysis — PR #903

Risk tier: 🟢 LOW

📊 Summary

Metric Count
Files changed 1
Files added 0
Files modified 1
Files deleted 0
Modules touched 1

🎯 Risk Factors

  • 1 files changed (≤5 → LOW)
  • 1 module(s) touched (≤1 → LOW)

📦 Modules Affected

ci-workflows (1 file)
  • .github/workflows/squad-ci.yml

This report is generated automatically for every PR. See #733 for details.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Squad CI workflow to avoid failing PRs that intentionally use prerelease package versions when the PR targets the insider branch.

Changes:

  • Adds an if: condition to skip the “Prerelease Version Guard” step when the PR base branch is insider.

@diberry diberry force-pushed the diberry/fix-version-guard-insider branch from d420490 to 116757f Compare April 8, 2026 14:22
@diberry diberry added the skip-changelog Skip changelog enforcement for this PR label Apr 8, 2026
@diberry
Copy link
Copy Markdown
Collaborator Author

diberry commented Apr 8, 2026

🔍 Squad Review — Kaylee (Engineering)

# Check Status Notes
1 Changelog entry skip-changelog label applied — CI-only change
2 Squashed to 1 commit 1 commit
3 CI green All checks passed
4 Copilot comments resolved 0 review threads
5 No .squad/ files Clean
6 No unrelated files 1 file — .github/workflows/squad-ci.yml only
7 Tests for changes CI workflow change — no testable product code
8 Not a duplicate/reversal Unique scope (fixes insider CI false positive)

Verdict: ✅ Ready to merge


Review by Squad AI team (Kaylee — Engineering) · requested by Dina Berry

@diberry diberry merged commit bda2d07 into dev Apr 8, 2026
12 checks passed
@diberry diberry changed the title ci: skip prerelease version guard on insider branch ci: skip prerelease version guard on insider branch [ON HOLD] Apr 8, 2026
tamirdresher pushed a commit that referenced this pull request Apr 21, 2026
Co-authored-by: Dina Berry <diberry@users.noreply.github.com>
@bradygaster
Copy link
Copy Markdown
Owner

Closed by #theSquadsquad triage — verified fixed in v0.9.4 (PR #908 merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip changelog enforcement for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants