ci: skip prerelease version guard on insider branch [ON HOLD]#903
Merged
ci: skip prerelease version guard on insider branch [ON HOLD]#903
Conversation
Contributor
🏗️ Architectural Review
Automated architectural review — informational only. |
Contributor
🟢 Impact Analysis — PR #903Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Squad CI workflow to avoid failing PRs that intentionally use prerelease package versions when the PR targets the insider branch.
Changes:
- Adds an
if:condition to skip the “Prerelease Version Guard” step when the PR base branch isinsider.
d420490 to
116757f
Compare
Collaborator
Author
🔍 Squad Review — Kaylee (Engineering)
Verdict: ✅ Ready to merge Review by Squad AI team (Kaylee — Engineering) · requested by Dina Berry |
tamirdresher
pushed a commit
that referenced
this pull request
Apr 21, 2026
Co-authored-by: Dina Berry <diberry@users.noreply.github.com>
Owner
|
Closed by #theSquadsquad triage — verified fixed in v0.9.4 (PR #908 merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skip the prerelease version guard when the PR targets the
insiderbranch.Why
The
prerelease-version-guardstep in Squad CI blocks packages with prerelease suffixes (e.g.,0.9.4-insider.1) from merging. This is correct for PRs targetingdevormain, but false-positive oninsiderwhere prerelease versions are expected and intentional.This causes every PR targeting
insiderto show a CI failure, including PR #900.How
Added one condition to the guard's
if:block:yaml && github.event.pull_request.base.ref != 'insider'1 file, 1 line added. The guard still runs on PRs to
dev,main, andpreview.Testing
if:block syntax is valid YAML multi-lineskip-version-checklabel still works as an escape hatch/cc @bradygaster @tamirdresher