fix: address post-merge review findings (#876, #900, #875) — type safety, YAML escaping#929
Closed
tamirdresher wants to merge 3 commits intobradygaster:insiderfrom
Closed
fix: address post-merge review findings (#876, #900, #875) — type safety, YAML escaping#929tamirdresher wants to merge 3 commits intobradygaster:insiderfrom
tamirdresher wants to merge 3 commits intobradygaster:insiderfrom
Conversation
…#900, bradygaster#875) - Add YAML value escaping helper for skill metadata - Replace catch(err: any) with catch(err: unknown) + narrowing - Add type guards to replace unsafe type assertions - Standardize deprecation messages on `gh copilot` - Fix unsafe exports type cast in cross-package test Closes bradygaster#924, bradygaster#925, bradygaster#926 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher
added
the
skip-version-check
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher
force-pushed
the
fix/876-type-safety
branch
from
a4176d4 to
489c73b
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher
changed the title
Collaborator
Author
|
Closing to re-open as fresh PR — CI not triggering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses post-merge review findings from PRs #876, #900, and #875.
Changes
escapeYamlValue()helper that wraps values containing:,#,',", or newlines in single quotes (with internal quote doubling). Applied inskill.tspublish andinit.tsgenerateApmYml.catch (err: unknown)— Replaced allcatch (err: any)withcatch (err: unknown)+instanceof Errornarrowing in skill.ts, init.ts, and plugin.ts (4 instances).isNamedPath()type guard to replace unsafeas { name: string; path: string }assertions in skill.ts (3 instances).copilottogh copilotin start and rc deprecation messages (cli-entry.ts).as Record<string, Record<string, string>>withRecord<string, unknown>+ runtime type narrowing in cross-package-exports.test.ts.Closes #924, #925, #926